From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.nokia.com ([147.243.1.47]:59603 "EHLO mgw-sa01.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214Ab0KIN0a (ORCPT ); Tue, 9 Nov 2010 08:26:30 -0500 Date: Tue, 9 Nov 2010 15:25:13 +0200 From: Heikki Krogerus Subject: Re: [PATCH v2] USB: Add MSM USB Device Controller driver Message-ID: <20101109132513.GC19113@esdhcp041123.research.nokia.com> References: <1289301494-26150-1-git-send-email-pkondeti@codeaurora.org> <1289301494-26150-2-git-send-email-pkondeti@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1289301494-26150-2-git-send-email-pkondeti@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: ext Pavankumar Kondeti Cc: "greg@kroah.com" , "linux-usb@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , Mike Lockwood , Brian Swetland On Tue, Nov 09, 2010 at 12:18:10PM +0100, ext Pavankumar Kondeti wrote: > This patch adds the basic support for the USB Device Controller on Qualcomm > MSM family of SOCs. The controller supports upto 16 endpoints including the > default endpoint (ep0). All the data transfers are driven by DMA. > > VBUS line is also connected to PMIC chip. The module controlling PMIC chip > notifies about cable connect/disconnect events. Hence, PHY comparators > are turned off in low power mode. > > This driver was originally developed by Google and is available at > http://android.git.kernel.org/?p=kernel/experimental.git. > > CC: Mike Lockwood > CC: Brian Swetland > Signed-off-by: Pavankumar Kondeti > --- > drivers/usb/gadget/Kconfig | 17 + > drivers/usb/gadget/Makefile | 1 + > drivers/usb/gadget/gadget_chips.h | 8 + > drivers/usb/gadget/msm72k_udc.c | 1685 +++++++++++++++++++++++++++++++++++++ > include/linux/usb/msm_hsusb.h | 38 + > include/linux/usb/msm_hsusb_hw.h | 184 ++++ > 6 files changed, 1933 insertions(+), 0 deletions(-) > create mode 100644 drivers/usb/gadget/msm72k_udc.c > create mode 100644 include/linux/usb/msm_hsusb.h > create mode 100644 include/linux/usb/msm_hsusb_hw.h > +#define ULPI_DEBUG_REG (0x15) > +#define ULPI_SCRATCH_REG (0x16) > + > +#define ULPI_FUNC_CTRL_CLR (0x06) > +#define ULPI_FUNC_SUSPENDM (1 << 6) No more redefinitions of ulpi regs. Just include usb/ulpi.h. -- heikki