Re: [PATCH 1/4] USB: Add MSM OTG Controller driver

[Pavan Kondeti <pkondeti@codeaurora.org>]

Hi Greg,

On Tue, Nov 16, 2010 at 01:43:46PM -0800, Greg KH wrote:
> On Tue, Nov 09, 2010 at 04:49:48PM +0530, Pavankumar Kondeti wrote:
> > This driver implements PHY initialization, clock management, memory mapping
> > register address space, ULPI IO ops and simple OTG state machine to kick
> > host/peripheral based on Id/VBUS line status.  VBUS/Id lines are tied to a
> > reference voltage on some boards.  Hence provide a sysfs interface to
> > select host/peripheral mode.
> 
> As you are creating a new user/kernel abi, it MUST be documented in the
> Documentation/ABI/ directory.  I can't take this patch set until that
> happens.
> 
Thanks for letting me know this. I will add the documentation for the sysfs file.

> Care to redo this one, and your device patch set based on the review
> comments there, and resend them?
> 
I have been advised to reuse the ci13xxx_udc.c gadget controller driver. The
driver currently supports PCI but not platform bus. I am working on making it
to support platform bus. I will post RFC patch soon. Meanwhile I am thinking
of resending host driver patches (as of now host/otg uses header files of device
controller driver). Is this fine?
-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.