From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:60943 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732Ab0KRFAV (ORCPT ); Thu, 18 Nov 2010 00:00:21 -0500 Date: Thu, 18 Nov 2010 10:30:16 +0530 From: Pavan Kondeti Subject: Re: [PATCH 1/4] USB: Add MSM OTG Controller driver Message-ID: <20101118050016.GA11700@codeaurora.org> References: <1289301591-26228-1-git-send-email-pkondeti@codeaurora.org> <1289301591-26228-2-git-send-email-pkondeti@codeaurora.org> <20101116214346.GA18387@kroah.com> <20101117102352.GA29845@codeaurora.org> <20101117161637.GE10992@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101117161637.GE10992@kroah.com> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Greg KH Cc: linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org Hi Greg, On Wed, Nov 17, 2010 at 08:16:37AM -0800, Greg KH wrote: > On Wed, Nov 17, 2010 at 03:53:52PM +0530, Pavan Kondeti wrote: > > Hi Greg, > > > > On Tue, Nov 16, 2010 at 01:43:46PM -0800, Greg KH wrote: > > > On Tue, Nov 09, 2010 at 04:49:48PM +0530, Pavankumar Kondeti wrote: > > > > This driver implements PHY initialization, clock management, memory mapping > > > > register address space, ULPI IO ops and simple OTG state machine to kick > > > > host/peripheral based on Id/VBUS line status. VBUS/Id lines are tied to a > > > > reference voltage on some boards. Hence provide a sysfs interface to > > > > select host/peripheral mode. > > > > > > As you are creating a new user/kernel abi, it MUST be documented in the > > > Documentation/ABI/ directory. I can't take this patch set until that > > > happens. > > > > > Thanks for letting me know this. I will add the documentation for the sysfs file. > > Also note that if you are adding a new ABI like this one, it needs to > work the same for the other existing OTG drivers as well. So please > also work to fix them to do the same thing, or change your code to work > like the existing drivers do (hint, do the latter one...) > I am not sure if other OTG driver require this sysfs file. USB mode i.e Host/Peripheral is changed based on Id/VBUS status. But on some of the MSM boards, Id/VBUS is connected to reference voltage and need an additional sysfs file for user to change the operation mode. Where should a driver specific sysfs file should go in Doc/ABI/ ? > > > Care to redo this one, and your device patch set based on the review > > > comments there, and resend them? > > > > > I have been advised to reuse the ci13xxx_udc.c gadget controller driver. The > > driver currently supports PCI but not platform bus. I am working on making it > > to support platform bus. I will post RFC patch soon. Meanwhile I am thinking > > of resending host driver patches (as of now host/otg uses header files of device > > controller driver). Is this fine? > > Would it make much sense to have the host code in the tree at this point > in time due to the other changes you are going to have to do for the > gadget controller? > May be, I should wait till gadget controller driver patches are ready to avoid any additional changes in otg driver for supporting gadget. -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.