From: Greg KH <gregkh@suse.de>
To: Tatyana Brokhman <tlinder@codeaurora.org>
Cc: linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] usb: Adding SuperSpeed support to dummy_hcd
Date: Thu, 18 Nov 2010 07:55:58 -0800 [thread overview]
Message-ID: <20101118155558.GA1941@suse.de> (raw)
In-Reply-To: <1290085052-4977-1-git-send-email-tlinder@codeaurora.org>
On Thu, Nov 18, 2010 at 02:57:32PM +0200, Tatyana Brokhman wrote:
> USB 3.0 hub includes 2 hubs - HS and SS ones.
> Thus, when dummy_hcd enabled it will register 2 root hubs (SS and HS).
>
> Signed-off-by: Tatyana Brokhman <tlinder@codeaurora.org>
{sigh}
This changelog entry makes absolutely no sense. Please write something
that describes what you are doing, and why you are doing it, with full
details (i.e. links to the tests you ran, etc.) Look at how other
people write their comments for major patches like this, be descriptive
and verbose. It will help when in 3 years you are asked why this patch
did what it did.
I'm sorry if it feels like I'm picking on you, but I'm trying to help
you get it right for this, and future contributions.
thanks,
greg k-h
next prev parent reply other threads:[~2010-11-18 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 12:57 [PATCH v6] usb: Adding SuperSpeed support to dummy_hcd Tatyana Brokhman
2010-11-18 15:55 ` Greg KH [this message]
2010-11-18 16:06 ` Alan Stern
2011-01-25 13:14 ` Tanya Brokhman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118155558.GA1941@suse.de \
--to=gregkh@suse.de \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tlinder@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).