From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:49807 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757046Ab0KRP7a (ORCPT ); Thu, 18 Nov 2010 10:59:30 -0500 Date: Thu, 18 Nov 2010 07:55:58 -0800 From: Greg KH Subject: Re: [PATCH v6] usb: Adding SuperSpeed support to dummy_hcd Message-ID: <20101118155558.GA1941@suse.de> References: <1290085052-4977-1-git-send-email-tlinder@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1290085052-4977-1-git-send-email-tlinder@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Tatyana Brokhman Cc: linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, David Brownell , linux-kernel@vger.kernel.org On Thu, Nov 18, 2010 at 02:57:32PM +0200, Tatyana Brokhman wrote: > USB 3.0 hub includes 2 hubs - HS and SS ones. > Thus, when dummy_hcd enabled it will register 2 root hubs (SS and HS). > > Signed-off-by: Tatyana Brokhman {sigh} This changelog entry makes absolutely no sense. Please write something that describes what you are doing, and why you are doing it, with full details (i.e. links to the tests you ran, etc.) Look at how other people write their comments for major patches like this, be descriptive and verbose. It will help when in 3 years you are asked why this patch did what it did. I'm sorry if it feels like I'm picking on you, but I'm trying to help you get it right for this, and future contributions. thanks, greg k-h