From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Walker <dwalker@codeaurora.org>
Cc: Brandon Leong <bleong@codeaurora.org>,
lrg@slimlogic.co.uk, davidb@codeaurora.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] regulator: debugfs: Adding debugfs functions into regulator framework
Date: Tue, 7 Dec 2010 11:57:01 +0000 [thread overview]
Message-ID: <20101207115701.GC4698@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1291690320.4150.1.camel@m0nster>
On Mon, Dec 06, 2010 at 06:52:00PM -0800, Daniel Walker wrote:
> On Mon, 2010-12-06 at 22:29 +0000, Mark Brown wrote:
> > > +static int reg_debug_enable_set(void *data, u64 val)
> > > +{
> > > + int err_info;
> > > + if (IS_ERR(data) || data == NULL) {
> > > + pr_err("Function Input Error %ld\n", PTR_ERR(data));
> > Please Try To Make Your Log Messages A Bit More Descriptive And
> > Typographically Correct - I'd not expect a user to have a hope of
> > figuring out what's gone wrong here. That said, I suspect you're
> > looking for BUG_ON() here...
> Could we do WARN_ON() here? Unless this is a really serious problem.
It means we've managed to let the user open a file without setting up
the private data for the file correctly which is a pretty bad bug which
we'd never expect to see at runtime unless there was a clear kernel bug.
next prev parent reply other threads:[~2010-12-07 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 20:52 [PATCH] regulator: debugfs: Adding debugfs functions into regulator framework Brandon Leong
2010-12-06 22:29 ` Mark Brown
2010-12-07 2:52 ` Daniel Walker
2010-12-07 11:57 ` Mark Brown [this message]
2010-12-07 22:04 ` Brandon Leong
2010-12-07 22:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207115701.GC4698@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=bleong@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).