From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:55921 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751630Ab0LGL5E (ORCPT ); Tue, 7 Dec 2010 06:57:04 -0500 Date: Tue, 7 Dec 2010 11:57:01 +0000 From: Mark Brown Subject: Re: [PATCH] regulator: debugfs: Adding debugfs functions into regulator framework Message-ID: <20101207115701.GC4698@rakim.wolfsonmicro.main> References: <1291668763-15734-1-git-send-email-bleong@codeaurora.org> <20101206222907.GA2425@opensource.wolfsonmicro.com> <1291690320.4150.1.camel@m0nster> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1291690320.4150.1.camel@m0nster> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Daniel Walker Cc: Brandon Leong , lrg@slimlogic.co.uk, davidb@codeaurora.org, linux-arm-msm@vger.kernel.org On Mon, Dec 06, 2010 at 06:52:00PM -0800, Daniel Walker wrote: > On Mon, 2010-12-06 at 22:29 +0000, Mark Brown wrote: > > > +static int reg_debug_enable_set(void *data, u64 val) > > > +{ > > > + int err_info; > > > + if (IS_ERR(data) || data == NULL) { > > > + pr_err("Function Input Error %ld\n", PTR_ERR(data)); > > Please Try To Make Your Log Messages A Bit More Descriptive And > > Typographically Correct - I'd not expect a user to have a hope of > > figuring out what's gone wrong here. That said, I suspect you're > > looking for BUG_ON() here... > Could we do WARN_ON() here? Unless this is a really serious problem. It means we've managed to let the user open a file without setting up the private data for the file correctly which is a pretty bad bug which we'd never expect to see at runtime unless there was a clear kernel bug.