From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na3sys009aog114.obsmtp.com ([74.125.149.211]:57551 "EHLO na3sys009aog114.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753152Ab0LOMSL (ORCPT ); Wed, 15 Dec 2010 07:18:11 -0500 Date: Wed, 15 Dec 2010 14:18:00 +0200 From: Felipe Balbi Subject: Re: [RFC 3/5] USB: gadget: OTG supplement revision 2.0 updates Message-ID: <20101215121800.GP2997@legolas.emea.dhcp.ti.com> Reply-To: balbi@ti.com References: <1292411654-21382-1-git-send-email-pkondeti@codeaurora.org> <1292411654-21382-4-git-send-email-pkondeti@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1292411654-21382-4-git-send-email-pkondeti@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Pavankumar Kondeti Cc: linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org Hi, On Wed, Dec 15, 2010 at 04:44:12PM +0530, Pavankumar Kondeti wrote: >@@ -1047,9 +1065,10 @@ composite_unbind(struct usb_gadget *gadget) > kfree(cdev->req->buf); > usb_ep_free_request(gadget->ep0, cdev->req); > } >+ device_remove_file(&gadget->dev, &dev_attr_host_request); >+ device_remove_file(&gadget->dev, &dev_attr_suspended); > kfree(cdev); > set_gadget_data(gadget, NULL); >- device_remove_file(&gadget->dev, &dev_attr_suspended); this looks like something that shouldn't be part of this patch ?!? -- balbi