From: Felipe Balbi <balbi@ti.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Felipe Balbi <balbi@ti.com>,
Pavankumar Kondeti <pkondeti@codeaurora.org>,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [RFC 2/5] USB: core: OTG Supplement Revision 2.0 updates
Date: Thu, 16 Dec 2010 10:10:16 +0200 [thread overview]
Message-ID: <20101216081016.GC2601@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1012151638260.2171-100000@iolanthe.rowland.org>
On Wed, Dec 15, 2010 at 04:39:13PM -0500, Alan Stern wrote:
>On Wed, 15 Dec 2010, Felipe Balbi wrote:
>
>> >+{
>> >+ int ret;
>> >+ struct usb_bus *bus =
>> >+ container_of(work, struct usb_bus, hnp_polling.work);
>> >+ struct usb_device *udev = bus->root_hub->children[bus->otg_port - 1];
>> >+ u8 *status = kmalloc(sizeof(*status), GFP_KERNEL);
>>
>> how about:
>>
>> u8 status;
>>
>> and...
>>
>> >+ if (!status)
>> >+ return;
>> >+
>> >+ ret = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
>> >+ USB_REQ_GET_STATUS, USB_DIR_IN | USB_RECIP_DEVICE,
>> >+ 0, OTG_STATUS_SELECTOR, status, sizeof(*status),
>>
>> 0, OTG_STATUS_SELECTOR, &status, sizeof(status);
>> ??
>
>You mustn't do DMA to addresses on the stack.
oh, ok. Forgot other controllers will do DMA for control message too.
MUSB won't.
--
balbi
next prev parent reply other threads:[~2010-12-16 8:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 11:14 [RFC 0/5] USB core changes for supporting OTG on MSM SoC Pavankumar Kondeti
2010-12-15 11:14 ` [RFC 1/5] USB: core: Add input prompt and help text for USB_OTG config Pavankumar Kondeti
2010-12-15 12:35 ` Sergei Shtylyov
2010-12-15 21:52 ` Greg KH
2010-12-16 8:53 ` Pavan Kondeti
2010-12-15 11:14 ` [RFC 2/5] USB: core: OTG Supplement Revision 2.0 updates Pavankumar Kondeti
2010-12-15 12:16 ` Felipe Balbi
2010-12-15 21:39 ` Alan Stern
2010-12-16 8:10 ` Felipe Balbi [this message]
2010-12-16 8:54 ` Pavan Kondeti
2010-12-16 9:11 ` Felipe Balbi
2010-12-15 21:29 ` Alan Stern
2010-12-16 8:54 ` Pavan Kondeti
2010-12-15 21:53 ` Greg KH
2010-12-16 8:54 ` Pavan Kondeti
2010-12-15 11:14 ` [RFC 3/5] USB: gadget: OTG supplement revision " Pavankumar Kondeti
2010-12-15 12:18 ` Felipe Balbi
2010-12-16 8:54 ` Pavan Kondeti
2010-12-15 11:14 ` [RFC 4/5] USB: EHCI: Notify HCD about HNP enabled port suspend Pavankumar Kondeti
2010-12-15 12:19 ` Felipe Balbi
2010-12-16 8:54 ` Pavan Kondeti
2010-12-15 11:14 ` [RFC 5/5] USB: Eliminate delays involved in root hub initialization during HNP Pavankumar Kondeti
2010-12-15 12:21 ` Felipe Balbi
2010-12-16 11:26 ` Pavan Kondeti
2010-12-16 12:15 ` Felipe Balbi
2010-12-16 12:53 ` Pavan Kondeti
2010-12-15 21:52 ` Greg KH
2010-12-15 21:38 ` [RFC 0/5] USB core changes for supporting OTG on MSM SoC Alan Stern
2010-12-16 8:55 ` Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216081016.GC2601@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pkondeti@codeaurora.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).