From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na3sys009aog105.obsmtp.com ([74.125.149.75]:42503 "EHLO na3sys009aog105.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752801Ab0LPJLU (ORCPT ); Thu, 16 Dec 2010 04:11:20 -0500 Date: Thu, 16 Dec 2010 11:11:09 +0200 From: Felipe Balbi Subject: Re: [RFC 2/5] USB: core: OTG Supplement Revision 2.0 updates Message-ID: <20101216091109.GH2601@legolas.emea.dhcp.ti.com> Reply-To: balbi@ti.com References: <1292411654-21382-1-git-send-email-pkondeti@codeaurora.org> <1292411654-21382-3-git-send-email-pkondeti@codeaurora.org> <20101215121616.GO2997@legolas.emea.dhcp.ti.com> <4D09D3AD.5080602@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <4D09D3AD.5080602@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Pavan Kondeti Cc: balbi@ti.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org Hi, On Thu, Dec 16, 2010 at 02:24:05PM +0530, Pavan Kondeti wrote: >>> @@ -1270,6 +1283,43 @@ static int usb_resume_both(struct usb_device *udev, pm_message_t msg) >>> return status; >>> } >>> >>> +#ifdef CONFIG_USB_OTG >>> +void usb_hnp_polling_work(struct work_struct *work) >> >> do you really need this to be exported ?? >> > >The work struct is per USB bus. The bus is initialized in core/hcd.c. I >kept the work function here as it it belongs to usb core (I mean not HCD >specific) like other USB auto suspend functions. I see, it wasn't obvious from the patch, sorry :-) -- balbi