From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jeff Ohlstein <johlstei@codeaurora.org>
Cc: "David Brown" <davidb@codeaurora.org>,
"Daniel Walker" <dwalker@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Brian Swetland" <swetland@google.com>,
"Dima Zavin" <dima@android.com>,
"Arve Hj�nnev�g" <arve@android.com>,
"Bryan Huntsman" <bryanh@codeaurora.org>
Subject: Re: [PATCH v5 5/5] msm: add SMP support for msm
Date: Thu, 16 Dec 2010 21:44:20 +0000 [thread overview]
Message-ID: <20101216214420.GX9937@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1292482456-22690-6-git-send-email-johlstei@codeaurora.org>
On Wed, Dec 15, 2010 at 10:54:16PM -0800, Jeff Ohlstein wrote:
> +void __cpuinit platform_secondary_init(unsigned int cpu)
> +{
> + /* Configure edge-triggered PPIs */
> + writel(GIC_PPI_EDGE_MASK, MSM_QGIC_DIST_BASE + GIC_DIST_CONFIG + 4);
At some point we should really clean this up so we don't have code
writing directly to the GIC registers like this.
> +static __init void prepare_cold_cpu(unsigned int cpu)
> +{
> + int ret;
> + ret = scm_set_boot_addr((void *)
> + virt_to_phys(msm_secondary_startup),
It seems wrong to cast a physical address to a pointer - physical
addresses should not be pointer-like. Can it stay as an integer?
next prev parent reply other threads:[~2010-12-16 21:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 6:54 [PATCH v5 0/5] SMP support for msm Jeff Ohlstein
2010-12-16 6:54 ` [PATCH v5 1/5] msm: Secure Channel Manager (SCM) support Jeff Ohlstein
2010-12-16 6:54 ` [PATCH v5 2/5] msm: scm-boot: Support for setting cold/warm boot addresses Jeff Ohlstein
2010-12-16 6:54 ` [PATCH v5 3/5] msm: timer: SMP timer support for msm Jeff Ohlstein
2010-12-16 6:54 ` [PATCH v5 4/5] msm: hotplug: support cpu hotplug on msm Jeff Ohlstein
2010-12-16 12:55 ` Catalin Marinas
2010-12-16 21:40 ` Jeff Ohlstein
2010-12-16 6:54 ` [PATCH v5 5/5] msm: add SMP support for msm Jeff Ohlstein
2010-12-16 21:44 ` Russell King - ARM Linux [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-14 4:50 [PATCH v4 0/5] " Jeff Ohlstein
2010-12-14 4:50 ` [PATCH v5 5/5] msm: add " Jeff Ohlstein
2010-12-15 12:35 ` Catalin Marinas
2010-12-15 13:44 ` David Brown
2010-12-15 16:03 ` Russell King - ARM Linux
2010-12-15 17:42 ` Steve Muckle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216214420.GX9937@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=arve@android.com \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dima@android.com \
--cc=dwalker@codeaurora.org \
--cc=johlstei@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).