From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Saravana Kannan <skannan@codeaurora.org>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Update consumer state only after set voltage succeeds.
Date: Mon, 20 Dec 2010 12:39:03 +0000 [thread overview]
Message-ID: <20101220123903.GE26706@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1292625868-26862-1-git-send-email-skannan@codeaurora.org>
On Fri, Dec 17, 2010 at 02:44:28PM -0800, Saravana Kannan wrote:
> static int regulator_check_consumers(struct regulator_dev *rdev,
> + struct regulator *ignore,
> int *min_uV, int *max_uV)
This feels really invasive, and prone to robustness issues as we're just
randomly not checking one of the consumers on a single call, meaning we
skip some checking some of the time. It's not going to make the code
more maintainable.
> - regulator->min_uV = min_uV;
> - regulator->max_uV = max_uV;
> -
> - ret = regulator_check_consumers(rdev, &min_uV, &max_uV);
> + ret = regulator_check_consumers(rdev, regulator, &min_uV, &max_uV);
> if (ret < 0)
> goto out;
>
> ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
> + if (!ret) {
> + regulator->min_uV = min_uV;
> + regulator->max_uV = max_uV;
> + }
If you're going to do something probably unwinding the assignment on
error would cover it.
next prev parent reply other threads:[~2010-12-20 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 22:44 [PATCH] regulator: Update consumer state only after set voltage succeeds Saravana Kannan
2010-12-20 12:39 ` Mark Brown [this message]
2010-12-20 22:27 ` Saravana Kannan
2010-12-21 16:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220123903.GE26706@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).