From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
Colin Cross <ccross@android.com>,
Daniel Walker <dwalker@codeaurora.org>,
David Brown <davidb@codeaurora.org>,
Erik Gilling <konkers@android.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Olof Johansson <olof@lixom.net>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Tony Lindgren <tony@atomide.com>,
linux-tegra@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] TWD: enable one-shot mode
Date: Tue, 11 Jan 2011 11:52:09 +0000 [thread overview]
Message-ID: <20110111115209.GA12781@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4D2BE6C4.4040806@codeaurora.org>
On Mon, Jan 10, 2011 at 09:12:36PM -0800, Stephen Boyd wrote:
> On 12/24/2010 11:18 AM, Russell King - ARM Linux wrote:
> > Allow one shot timer mode to be used with the TWD. This allows
> > NOHZ mode to be used on SMP systems using the TWD localtimer.
> >
> > Tested on Versatile Express.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > ---
> > Acks/Tested-by's would be appreciated, thanks.
> >
>
> I see this patch was already tested and merged but can you elaborate on
> why this was done? From what I understand, NOHZ selects one-shot (like
> is done in this patch), so why don't the machines with a TWD choose NOHZ
> or high res timers?
You're right - so it's not actually required. It should probably be
reverted, though it does no damage...
next prev parent reply other threads:[~2011-01-11 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-24 19:18 [PATCH] TWD: enable one-shot mode Russell King - ARM Linux
2010-12-28 1:17 ` Linus Walleij
2011-01-11 5:12 ` Stephen Boyd
2011-01-11 11:52 ` Russell King - ARM Linux [this message]
2011-01-14 18:45 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111115209.GA12781@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=bryanh@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=ccross@android.com \
--cc=davidb@codeaurora.org \
--cc=dwalker@codeaurora.org \
--cc=kgene.kim@samsung.com \
--cc=konkers@android.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sboyd@codeaurora.org \
--cc=srinidhi.kasagar@stericsson.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).