From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Daniel Walker <dwalker@codeaurora.org>
Cc: davidb@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] drivers: mmc: msm: update to new arm pfn_to_dma API
Date: Tue, 18 Jan 2011 21:16:06 +0000 [thread overview]
Message-ID: <20110118211606.GM16980@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1295384420.26904.56.camel@c-dwalke-linux.qualcomm.com>
On Tue, Jan 18, 2011 at 01:00:20PM -0800, Daniel Walker wrote:
> Just greping the driver I found at least one writel() .. I'm not really
> concerned with that tho. I use this driver, I need this driver to work.
> You broke the driver, and your NAK'ing the fix ..
If drivers use documented internal APIs, they _will_ break, and that's
tough luck. The advertised API (DMA-mapping) is what we guarantee to
support and fixup drivers for.
If you don't know that a driver is using an internal API then you can't
preempt it breaking. The answer is drivers must not use internal APIs.
Had the driver been properly reviewed before being merged, it should
have been caught before it was merged.
I've given you the outline of a proper fix, and you've probably already
spent longer discussing it than it would take you to cut'n'paste the
code into kernel and test it...
next prev parent reply other threads:[~2011-01-18 21:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 18:04 [PATCH] drivers: mmc: msm: update to new arm pfn_to_dma API Daniel Walker
2011-01-18 18:28 ` Russell King - ARM Linux
2011-01-18 20:22 ` Daniel Walker
2011-01-18 20:44 ` Russell King - ARM Linux
2011-01-18 21:00 ` Daniel Walker
2011-01-18 21:16 ` Russell King - ARM Linux [this message]
2011-01-18 21:28 ` Daniel Walker
2011-01-18 22:41 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118211606.GM16980@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=davidb@quicinc.com \
--cc=dwalker@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).