Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

[Stanislaw Gruszka]

On Mon, Jan 03, 2011 at 02:49:43PM +0100, Tejun Heo wrote:
> With cmwq, there's no reason to use separate workqueues.  Drop
> msmfb_info->resume_workqueue and use system_wq instead.
> 
> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Stanislaw Gruszka <stf_xl-5tc4TXWwyLM@public.gmane.org>
I'm not the right person, CC according to MAINTAINERS

> Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> ---
> Only compile tested.  Please feel free to take it into the subsystem
> tree or simply ack - I'll route it through the wq tree.
> 
> Thanks.
> 
>  drivers/video/msm/msm_fb.c |   11 +----------
>  1 files changed, 1 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/video/msm/msm_fb.c b/drivers/video/msm/msm_fb.c
> index debe593..5436aeb 100644
> --- a/drivers/video/msm/msm_fb.c
> +++ b/drivers/video/msm/msm_fb.c
> @@ -81,7 +81,6 @@ struct msmfb_info {
>  	spinlock_t update_lock;
>  	struct mutex panel_init_lock;
>  	wait_queue_head_t frame_wq;
> -	struct workqueue_struct *resume_workqueue;
>  	struct work_struct resume_work;
>  	struct msmfb_callback dma_callback;
>  	struct msmfb_callback vsync_callback;
> @@ -111,7 +110,7 @@ static void msmfb_handle_dma_interrupt(struct msmfb_callback *callback)
>  	if (msmfb->sleeping == UPDATING &&
>  	    msmfb->frame_done == msmfb->update_frame) {
>  		DLOG(SUSPEND_RESUME, "full update completed\n");
> -		queue_work(msmfb->resume_workqueue, &msmfb->resume_work);
> +		schedule_work(&msmfb->resume_work);
>  	}
>  	spin_unlock_irqrestore(&msmfb->update_lock, irq_flags);
>  	wake_up(&msmfb->frame_wq);
> @@ -559,12 +558,6 @@ static int msmfb_probe(struct platform_device *pdev)
>  	spin_lock_init(&msmfb->update_lock);
>  	mutex_init(&msmfb->panel_init_lock);
>  	init_waitqueue_head(&msmfb->frame_wq);
> -	msmfb->resume_workqueue = create_workqueue("panel_on");
> -	if (msmfb->resume_workqueue == NULL) {
> -		printk(KERN_ERR "failed to create panel_on workqueue\n");
> -		ret = -ENOMEM;
> -		goto error_create_workqueue;
> -	}
>  	INIT_WORK(&msmfb->resume_work, power_on_panel);
>  	msmfb->black = kzalloc(msmfb->fb->var.bits_per_pixel*msmfb->xres,
>  			       GFP_KERNEL);
> @@ -589,8 +582,6 @@ static int msmfb_probe(struct platform_device *pdev)
>  	return 0;
>  
>  error_register_framebuffer:
> -	destroy_workqueue(msmfb->resume_workqueue);
> -error_create_workqueue:
>  	iounmap(fb->screen_base);
>  error_setup_fbmem:
>  	framebuffer_release(msmfb->fb);
> -- 
> 1.7.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

[Daniel Walker]

On Mon, 2011-01-03 at 18:06 +0100, Stanislaw Gruszka wrote:
> On Mon, Jan 03, 2011 at 02:49:43PM +0100, Tejun Heo wrote:
> > With cmwq, there's no reason to use separate workqueues.  Drop
> > msmfb_info->resume_workqueue and use system_wq instead.
> > 
> > Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > Cc: Stanislaw Gruszka <stf_xl-5tc4TXWwyLM@public.gmane.org>
> I'm not the right person, CC according to MAINTAINERS

ARM/QUALCOMM MSM MACHINE SUPPORT
M:      David Brown <davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
M:      Daniel Walker <dwalker-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
M:      Bryan Huntsman <bryanh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
L:      linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
F:      arch/arm/mach-msm/
F:      drivers/video/msm/
F:      drivers/mmc/host/msm_sdcc.c
F:      drivers/mmc/host/msm_sdcc.h
F:      drivers/serial/msm_serial.h
F:      drivers/serial/msm_serial.c
T:      git git://codeaurora.org/quic/kernel/davidb/linux-msm.git
S:      Maintained



-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

[Tejun Heo]

On Mon, Jan 03, 2011 at 10:10:45AM -0800, Daniel Walker wrote:
> On Mon, 2011-01-03 at 18:06 +0100, Stanislaw Gruszka wrote:
> > On Mon, Jan 03, 2011 at 02:49:43PM +0100, Tejun Heo wrote:
> > > With cmwq, there's no reason to use separate workqueues.  Drop
> > > msmfb_info->resume_workqueue and use system_wq instead.
> > > 
> > > Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > > Cc: Stanislaw Gruszka <stf_xl-5tc4TXWwyLM@public.gmane.org>
> > I'm not the right person, CC according to MAINTAINERS
> 
> ARM/QUALCOMM MSM MACHINE SUPPORT
> M:      David Brown <davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> M:      Daniel Walker <dwalker-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> M:      Bryan Huntsman <bryanh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>

Oops, sorry about that.  So how does the patch look?  Are you gonna
take it through msm tree or shall I take it?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

[Daniel Walker]

On Tue, 2011-01-25 at 14:45 +0100, Tejun Heo wrote:
> On Mon, Jan 03, 2011 at 10:10:45AM -0800, Daniel Walker wrote:
> > On Mon, 2011-01-03 at 18:06 +0100, Stanislaw Gruszka wrote:
> > > On Mon, Jan 03, 2011 at 02:49:43PM +0100, Tejun Heo wrote:
> > > > With cmwq, there's no reason to use separate workqueues.  Drop
> > > > msmfb_info->resume_workqueue and use system_wq instead.
> > > > 
> > > > Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > > > Cc: Stanislaw Gruszka <stf_xl-5tc4TXWwyLM@public.gmane.org>
> > > I'm not the right person, CC according to MAINTAINERS
> > 
> > ARM/QUALCOMM MSM MACHINE SUPPORT
> > M:      David Brown <davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> > M:      Daniel Walker <dwalker-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> > M:      Bryan Huntsman <bryanh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> 
> Oops, sorry about that.  So how does the patch look?  Are you gonna
> take it through msm tree or shall I take it?

David ?

Daniel

-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

[David Brown]

On Tue, Jan 25 2011, Daniel Walker wrote:

> On Tue, 2011-01-25 at 14:45 +0100, Tejun Heo wrote:
>> On Mon, Jan 03, 2011 at 10:10:45AM -0800, Daniel Walker wrote:
>> > On Mon, 2011-01-03 at 18:06 +0100, Stanislaw Gruszka wrote:
>> > > On Mon, Jan 03, 2011 at 02:49:43PM +0100, Tejun Heo wrote:
>> > > > With cmwq, there's no reason to use separate workqueues.  Drop
>> > > > msmfb_info->resume_workqueue and use system_wq instead.
>> > > > 
>> > > > Signed-off-by: Tejun Heo <tj@kernel.org>
>> > > > Cc: Stanislaw Gruszka <stf_xl@wp.pl>
>> > > I'm not the right person, CC according to MAINTAINERS
>> > 
>> > ARM/QUALCOMM MSM MACHINE SUPPORT
>> > M:      David Brown <davidb@codeaurora.org>
>> > M:      Daniel Walker <dwalker@codeaurora.org>
>> > M:      Bryan Huntsman <bryanh@codeaurora.org>
>> 
>> Oops, sorry about that.  So how does the patch look?  Are you gonna
>> take it through msm tree or shall I take it?
>
> David ?
>
> Daniel

Is it difficult for you to test this change, Daniel?  I can pull it in
once we verify it still works.

Thanks,
David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

[Daniel Walker]

On Tue, 2011-01-25 at 11:14 -0800, David Brown wrote:
> On Tue, Jan 25 2011, Daniel Walker wrote:
> 
> > On Tue, 2011-01-25 at 14:45 +0100, Tejun Heo wrote:
> >> On Mon, Jan 03, 2011 at 10:10:45AM -0800, Daniel Walker wrote:
> >> > On Mon, 2011-01-03 at 18:06 +0100, Stanislaw Gruszka wrote:
> >> > > On Mon, Jan 03, 2011 at 02:49:43PM +0100, Tejun Heo wrote:
> >> > > > With cmwq, there's no reason to use separate workqueues.  Drop
> >> > > > msmfb_info->resume_workqueue and use system_wq instead.
> >> > > > 
> >> > > > Signed-off-by: Tejun Heo <tj@kernel.org>
> >> > > > Cc: Stanislaw Gruszka <stf_xl@wp.pl>
> >> > > I'm not the right person, CC according to MAINTAINERS
> >> > 
> >> > ARM/QUALCOMM MSM MACHINE SUPPORT
> >> > M:      David Brown <davidb@codeaurora.org>
> >> > M:      Daniel Walker <dwalker@codeaurora.org>
> >> > M:      Bryan Huntsman <bryanh@codeaurora.org>
> >> 
> >> Oops, sorry about that.  So how does the patch look?  Are you gonna
> >> take it through msm tree or shall I take it?
> >
> > David ?
> >
> > Daniel
> 
> Is it difficult for you to test this change, Daniel?  I can pull it in
> once we verify it still works.

Carl V. can test it, and review it I think ..

Daniel

-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

[Carl Vanderlip]

On Tue, 2011-01-25 at 11:16 -0800, Daniel Walker wrote:
> On Tue, 2011-01-25 at 11:14 -0800, David Brown wrote:
> > On Tue, Jan 25 2011, Daniel Walker wrote:
> > 
> > > On Tue, 2011-01-25 at 14:45 +0100, Tejun Heo wrote:
> > >> On Mon, Jan 03, 2011 at 10:10:45AM -0800, Daniel Walker wrote:
> > >> > On Mon, 2011-01-03 at 18:06 +0100, Stanislaw Gruszka wrote:
> > >> > > On Mon, Jan 03, 2011 at 02:49:43PM +0100, Tejun Heo wrote:
> > >> > > > With cmwq, there's no reason to use separate workqueues.  Drop
> > >> > > > msmfb_info->resume_workqueue and use system_wq instead.
> > >> > > > 
> > >> > > > Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > >> > > > Cc: Stanislaw Gruszka <stf_xl-5tc4TXWwyLM@public.gmane.org>
> > >> > > I'm not the right person, CC according to MAINTAINERS
> > >> > 
> > >> > ARM/QUALCOMM MSM MACHINE SUPPORT
> > >> > M:      David Brown <davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> > >> > M:      Daniel Walker <dwalker-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> > >> > M:      Bryan Huntsman <bryanh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> > >> 
> > >> Oops, sorry about that.  So how does the patch look?  Are you gonna
> > >> take it through msm tree or shall I take it?
> > >
> > > David ?
> > >
> > > Daniel
> > 
> > Is it difficult for you to test this change, Daniel?  I can pull it in
> > once we verify it still works.
> 
> Carl V. can test it, and review it I think ..
> 
> Daniel

Tested booting on MSM7X00A; appears to work fine (all I checked was that
it arrived at a buildroot login prompt).

Carl V.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

[David Brown]

On Mon, Jan 03 2011, Tejun Heo wrote:

> With cmwq, there's no reason to use separate workqueues.  Drop
> msmfb_info->resume_workqueue and use system_wq instead.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Stanislaw Gruszka <stf_xl@wp.pl>
> Cc: linux-usb@vger.kernel.org
> ---
> Only compile tested.  Please feel free to take it into the subsystem
> tree or simply ack - I'll route it through the wq tree.

I'll pull this into the MSM tree.

Thanks,
David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

[Tejun Heo]

On Tue, Jan 25, 2011 at 03:21:31PM -0800, David Brown wrote:
> On Mon, Jan 03 2011, Tejun Heo wrote:
> 
> > With cmwq, there's no reason to use separate workqueues.  Drop
> > msmfb_info->resume_workqueue and use system_wq instead.
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Cc: Stanislaw Gruszka <stf_xl@wp.pl>
> > Cc: linux-usb@vger.kernel.org
> > ---
> > Only compile tested.  Please feel free to take it into the subsystem
> > tree or simply ack - I'll route it through the wq tree.
> 
> I'll pull this into the MSM tree.

I suppose it will show up in linux-next?  I'm planning on marking
flush_scheduled_work() deprecated there soonish, so...

Thanks.

-- 
tejun

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

[David Brown]

On Wed, Jan 26 2011, Tejun Heo wrote:

> On Tue, Jan 25, 2011 at 03:21:31PM -0800, David Brown wrote:

> I suppose it will show up in linux-next?  I'm planning on marking
> flush_scheduled_work() deprecated there soonish, so...

Hmm, it should be there.  Well, it will at least be there when the next
linux-next tree comes out.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.