From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [Qualcomm PM8921 MFD 2/6] mfd: pm8xxx: Add irq support
Date: Thu, 3 Mar 2011 15:22:42 +0000
Message-ID: <20110303152242.GB32234@opensource.wolfsonmicro.com>
References: <1299104001-5240-1-git-send-email-adharmap@codeaurora.org>
 <1299104001-5240-3-git-send-email-adharmap@codeaurora.org>
 <20110302224616.GB32325@opensource.wolfsonmicro.com>
 <4D6F1B2B.3090706@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from opensource.wolfsonmicro.com ([80.75.67.52]:59096 "EHLO
	opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1758218Ab1CCPWV (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Thu, 3 Mar 2011 10:22:21 -0500
Content-Disposition: inline
In-Reply-To: <4D6F1B2B.3090706@codeaurora.org>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Cc: davidb@codeaurora.org, "David S. Miller" <davem@davemloft.net>, Andrew Morton <akpm@linux-foundation.org>, Bryan Huntsman <bryanh@codeaurora.org>, Daniel Walker <dwalker@fifo99.com>, David Collins <collinsd@codeaurora.org>, Grant Likely <grant.likely@secretlab.ca>, Greg Kroah-Hartman <gregkh@suse.de>, Joe Perches <joe@perches.com>, Russell King <linux@arm.linux.org.uk>, Samuel Ortiz <sameo@linux.intel.com>, Stepan Moskovchenko <stepanm@codeaurora.org>, Linus Walleij <linux.walleij@sterricsson.com>, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org

On Wed, Mar 02, 2011 at 08:38:03PM -0800, Abhijeet Dharmapurikar wrote:
> Mark Brown wrote:

> >Is it really useful to register a struct device purely for the interrupt
> >controller?  I'd have expected this to be core functionality of the
> >device.  The fact that you need to store the device at all is a bit odd
> >too as you're using the MFD API.

> This design is slightly different from other MFD drivers.
> I separated the interrupt from the core because the interrupt
> implementation for different Qualcomm pmics remains the same. On
> 8660 FFA boards for example, we have two pmic chips that have the
> same interrupt subdevice implementation (the number of interrupts
> managed by each is different). I didn't want to duplicate the exact
> code in the core driver - hence a separate interrupt driver.

Could you deal with this with a library instead?

> With that in mind, the driver has following functions
> pm8xxxx_read_root
> pm8xxxx_read_master
> pm8xxxx_read_block

> Do you still think I should change the name?

I'd suggest adding an _irq in there.