From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 2/5 v6] usb: Add usb_endpoint_descriptor to be part of the struct usb_ep Date: Fri, 25 Mar 2011 15:42:51 +0200 Message-ID: <20110325134248.GN2609@legolas.emea.dhcp.ti.com> References: <1300867420-20864-1-git-send-email-tlinder@codeaurora.org> Reply-To: balbi@ti.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog115.obsmtp.com ([74.125.149.238]:58120 "EHLO na3sys009aog115.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752429Ab1CYNnC (ORCPT ); Fri, 25 Mar 2011 09:43:02 -0400 Content-Disposition: inline In-Reply-To: <1300867420-20864-1-git-send-email-tlinder@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Tatyana Brokhman Cc: gregkh@suse.de, linux-arm-msm@vger.kernel.org, balbi@ti.com, ablay@codeaurora.org, "open list:USB GADGET/PERIPH..." , open list On Wed, Mar 23, 2011 at 10:03:38AM +0200, Tatyana Brokhman wrote: > Change usb_ep_enable() prototype to use endpoint descriptor from usb_ep. > This optimization spares the FDs from saving the endpoint chosen > descriptor. This optimization is not full though. To fully exploit this > change one needs to update all the UDCs as well since in the current > implementation each of them saves the endpoint descriptor in it's > internal (and extended) endpoint structure. I'm not sure this is such a good patch. But I don't have strong arguments against it either. > Signed-off-by: Tatyana Brokhman missing tear line -- balbi