From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 1/5 v8] usb: Adding SuperSpeed support to dummy_hcd Date: Fri, 25 Mar 2011 15:47:31 +0200 Message-ID: <20110325134730.GO2609@legolas.emea.dhcp.ti.com> References: <1300867372-20811-1-git-send-email-tlinder@codeaurora.org> Reply-To: balbi-l0cyMroinI0@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1300867372-20811-1-git-send-email-tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tatyana Brokhman Cc: gregkh-l3A5Bk7waGM@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, ablay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, "open list:USB GADGET/PERIPH..." , open list List-Id: linux-arm-msm@vger.kernel.org Hi, On Wed, Mar 23, 2011 at 10:02:51AM +0200, Tatyana Brokhman wrote: > This patch adds SS support to the dummy hcd module. It may be used to test > SS device when no (SS) HW is available. > USB 3.0 hub includes 2 hubs - HS and SS ones. > This patch adds support for a SS hub in the dummy_hcd module. Thus, when > dummy_hcd enabled it will register 2 root hubs (SS and HS). > > Signed-off-by: Tatyana Brokhman missing tear line. > diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c > index 3214ca3..4f4db96 100644 > --- a/drivers/usb/gadget/dummy_hcd.c > +++ b/drivers/usb/gadget/dummy_hcd.c > @@ -62,9 +62,12 @@ > #define POWER_BUDGET 500 /* in mA; use 8 for low-power port testing */ > > static const char driver_name [] = "dummy_hcd"; > +static const char ss_driver_name[] = "ss_dummy_hcd"; > static const char driver_desc [] = "USB Host+Gadget Emulator"; > +static const char ss_driver_desc[] = "SS USB Host+Gadget Emulator"; > > static const char gadget_name [] = "dummy_udc"; > +static const char ss_gadget_name[] = "ss_dummy_udc"; > > MODULE_DESCRIPTION (DRIVER_DESC); > MODULE_AUTHOR ("David Brownell"); > @@ -220,6 +223,7 @@ static inline struct dummy *gadget_dev_to_dummy (struct device *dev) > } > > static struct dummy *the_controller; > +static struct dummy *the_ss_controller; the only thing I don't like, is why you splitted the ss controller to a separate controller. Why don't you use the same ? From SW perspective, we can treat SS and HS/FS/LS controllers as one unit. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html