From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/2] regulator: Remove possible deadlock from regulator_enable Date: Mon, 28 Mar 2011 19:11:51 +0100 Message-ID: <20110328181151.GB28494@opensource.wolfsonmicro.com> References: <1301326482-6547-1-git-send-email-collinsd@codeaurora.org> <1301326482-6547-2-git-send-email-collinsd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:47332 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754697Ab1C1SLp (ORCPT ); Mon, 28 Mar 2011 14:11:45 -0400 Content-Disposition: inline In-Reply-To: <1301326482-6547-2-git-send-email-collinsd@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: David Collins Cc: Liam Girdwood , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm-owner@vger.kernel.org On Mon, Mar 28, 2011 at 08:34:41AM -0700, David Collins wrote: Review curtailed by me having to dash off but one comment... > -/* locks held by regulator_enable() */ > +/* Locks are *not* held by regulator_enable(). */ > static int _regulator_enable(struct regulator_dev *rdev) > { > - int ret, delay; > + struct regulator_dev *supply_rdev = NULL; > + int ret = 0, delay; > > + mutex_lock(&rdev->mutex); This is going to be terribly confusing - the _ versions of the functions all by convention rely on their callers taking the mutex, allowing them to be safely used from internal APIs.