From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [PATCH 2/5 v6] usb: Add usb_endpoint_descriptor to be part of the struct usb_ep Date: Mon, 11 Apr 2011 16:39:30 +0200 Message-ID: <20110411143930.GD4018@linutronix.de> References: <1300867420-20864-1-git-send-email-tlinder@codeaurora.org> <20110325134248.GN2609@legolas.emea.dhcp.ti.com> <000301cbec7a$3ff5cdf0$bfe169d0$@org> <20110328084624.GI2251@legolas.emea.dhcp.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Return-path: Content-Disposition: inline In-Reply-To: <20110328084624.GI2251-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Felipe Balbi Cc: Tanya Brokhman , gregkh-l3A5Bk7waGM@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ablay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, "'open list:USB GADGET/PERIPH...'" , 'open list' List-Id: linux-arm-msm@vger.kernel.org * Felipe Balbi | 2011-03-28 11:46:25 [+0300]: >> Could you please share you concerns? Even if they are not strong arguments >> :). >> Our pros for this change were that it seems more accurate that the EP >> descriptor will be handled by the composite layer and not the FDs. Thus we >> tried to spare the FD from saving the chosen EP descriptor and passing it to >> different functions. >> This change is needed for our algorithm of SS implementation in the later >> patches in this series. > >Yes, I understood that much, but it's useful for UDCs to access the EP >descriptor (ok, we can still access it by dereferencing ep) since we can >(actually we need to) use that to let the HW know about max packet >sizes, endpoint types, etc etc. > >Also, I'm not sure composite.c should know the details about the >endpoint. That's just a thin layer implementing the more generic part >(standard usb requests, handling, helpers for finding endpoints, etc), >but the one who should look into endpoint descriptors is the underlying >controller code for the reasons I listed above. > >That's my feeling... If I look at the diffstat between patch 2 and 4 I see | 30 files changed, 299 insertions(+), 393 deletions(-) So she got rid of almost 100 lines. While looking at the code it seems that every gadget driver does the same thing which is now done in one place. I like that so far :) Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html