From: Felipe Balbi <balbi@ti.com>
To: Pavan Kondeti <pkondeti@codeaurora.org>
Cc: balbi@ti.com, greg@kroah.com, linux-usb@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] USB: Fix trout build failure with ci13xxx_msm gadget
Date: Wed, 13 Apr 2011 11:24:21 +0300 [thread overview]
Message-ID: <20110413082419.GW15130@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <4D9D932D.6000903@codeaurora.org>
On Thu, Apr 07, 2011 at 04:04:21PM +0530, Pavan Kondeti wrote:
> On 4/5/2011 6:25 PM, Felipe Balbi wrote:
> > On Fri, Feb 04, 2011 at 10:08:18AM +0530, Pavankumar Kondeti wrote:
> >> This patch fixes the below compilation errors.
> >>
> >> CC drivers/usb/gadget/ci13xxx_msm.o
> >> CC net/mac80211/led.o
> >> drivers/usb/gadget/ci13xxx_msm.c: In function 'ci13xxx_msm_notify_event':
> >> drivers/usb/gadget/ci13xxx_msm.c:42: error: 'USB_AHBBURST' undeclared (first use in this function)
> >> drivers/usb/gadget/ci13xxx_msm.c:42: error: (Each undeclared identifier is reported only once
> >> drivers/usb/gadget/ci13xxx_msm.c:42: error: for each function it appears in.)
> >> drivers/usb/gadget/ci13xxx_msm.c:43: error: 'USB_AHBMODE' undeclared (first use in this function)
> >> make[4]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1
> >> make[3]: *** [drivers/usb/gadget] Error 2
> >>
> >> MSM USB driver is not supported on boards like trout (MSM7201) which
> >> has an external PHY.
> >>
> >> Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
> >
> > the real fix, though, would be to phase out the PHY to
> > drivers/usb/otg/blablabla.c. ci13xxx_msm.c shouldn't assume the PHY it's
> > using. That's wrong.
> >
> Agreed. Thanks for pointing this out.
>
> I think OTG driver should bail out if the PHY (or SoC) is not supported;
> which means otg_get_transceiver() returns NULL and gadget/host driver's
> probe also will fail.
correct :-)
--
balbi
prev parent reply other threads:[~2011-04-13 8:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 4:38 [PATCH] USB: Fix trout build failure with ci13xxx_msm gadget Pavankumar Kondeti
2011-02-04 22:07 ` Daniel Walker
2011-02-04 22:14 ` Bryan Huntsman
2011-02-04 22:14 ` David Brown
2011-04-05 12:55 ` Felipe Balbi
2011-04-07 10:34 ` Pavan Kondeti
2011-04-13 8:24 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110413082419.GW15130@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=greg@kroah.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pkondeti@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).