From: Felipe Balbi <balbi@ti.com>
To: Tatyana Brokhman <tlinder@codeaurora.org>
Cc: greg@kroah.com, linux-usb@vger.kernel.org,
linux-arm-msm@vger.kernel.org, balbi@ti.com,
ablay@codeaurora.org, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 4/7] usb:gadget: Add SuperSpeed support to the Gadget Framework
Date: Wed, 18 May 2011 13:10:53 +0300 [thread overview]
Message-ID: <20110518101049.GK11981@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1305637403-3832-5-git-send-email-tlinder@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
Hi,
On Tue, May 17, 2011 at 04:03:18PM +0300, Tatyana Brokhman wrote:
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index 5780f35..5be5f6d 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -352,7 +392,9 @@ static int config_buf(struct usb_configuration *config,
> list_for_each_entry(f, &config->functions, list) {
> struct usb_descriptor_header **descriptors;
>
> - if (speed == USB_SPEED_HIGH)
> + if (speed == USB_SPEED_SUPER)
> + descriptors = f->ss_descriptors;
> + else if (speed == USB_SPEED_HIGH)
> descriptors = f->hs_descriptors;
on the previous version of this patch I remember asking to convert these
to switch() instead :-)
same to all others below
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-05-18 10:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 13:03 [PATCH v10 0/7] usb gadget: Add SuperSpeed support to the Gadget Framework Tatyana Brokhman
2011-05-17 13:03 ` [PATCH/RESEND v10 1/7] usb: Add usb_endpoint_descriptor to be part of the struct usb_ep Tatyana Brokhman
2011-05-17 13:03 ` [PATCH/RESEND v10 2/7] usb: Configure endpoint according to gadget speed Tatyana Brokhman
2011-05-18 10:08 ` Felipe Balbi
2011-05-17 13:03 ` [PATCH/RESEND v10 3/7] usb: Modify existing gadget drivers to use config_ep_by_speed() instead of ep_choose Tatyana Brokhman
2011-05-17 13:03 ` [PATCH v10 4/7] usb:gadget: Add SuperSpeed support to the Gadget Framework Tatyana Brokhman
2011-05-18 10:10 ` Felipe Balbi [this message]
2011-05-17 13:03 ` [PATCH/RESEND v10 5/7] usb: Add streams support to the gadget framework Tatyana Brokhman
2011-05-17 13:03 ` [PATCH/RESEND v10 6/7] usb:gadget: Introduce usb_generate_ss_descriptors() Tatyana Brokhman
2011-05-18 10:12 ` Felipe Balbi
2011-05-17 13:03 ` [PATCH v10 7/7] usb: Adding SuperSpeed support to dummy_hcd Tatyana Brokhman
2011-05-18 10:17 ` Felipe Balbi
2011-05-17 18:09 ` [PATCH v10 0/7] usb gadget: Add SuperSpeed support to the Gadget Framework Greg KH
2011-05-17 18:52 ` Tanya Brokhman
2011-05-17 18:59 ` Greg KH
2011-05-17 19:20 ` Tanya Brokhman
2011-05-18 10:18 ` Felipe Balbi
[not found] ` <20110518101832.GN11981-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-05-18 13:53 ` Greg KH
2011-05-18 14:45 ` Felipe Balbi
2011-05-19 5:09 ` Tanya Brokhman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518101049.GK11981@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=ablay@codeaurora.org \
--cc=greg@kroah.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tlinder@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).