Re: [PATCH v11 2/7] usb: Configure endpoint according to gadget speed.

[Sebastian Andrzej Siewior <bigeasy@linutronix.de>]

* Tatyana Brokhman | 2011-05-19 14:43:27 [+0300]:

>diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
>index 5cbb1a4..cfba1ee 100644
>--- a/drivers/usb/gadget/composite.c
>+++ b/drivers/usb/gadget/composite.c
>@@ -27,6 +27,7 @@
> #include <linux/utsname.h>
> 
> #include <linux/usb/composite.h>
>+#include <linux/byteorder/generic.h>

Just applied that patch on v39 + usb-next nad it builds without this
line. Why is it required?

>diff --git a/include/linux/usb/composite.h b/include/linux/usb/composite.h
>index b78cba4..324fbc7 100644
>--- a/include/linux/usb/composite.h
>+++ b/include/linux/usb/composite.h
>@@ -146,6 +146,27 @@ int usb_function_activate(struct usb_function *);
> int usb_interface_id(struct usb_configuration *, struct usb_function *);
> 
> /**
>+ * config_ep_by_speed() - configures the given endpoint
>+ * according to gadget speed.
>+ * @g: pointer to the gadget
>+ * @f: usb function
>+ * @_ep: the endpoint to configure
>+ *
>+ * Return: error code, 0 on success
>+ *
>+ * This function chooses the right descriptors for a given
>+ * endpoint according to gadget speed and saves it in the
>+ * endpoint desc field. If the endpoint already has a descriptor
>+ * assigned to it - overwrites it with currently corresponding
>+ * descriptor. The endpoint maxpacket field is updated according
>+ * to the chosen descriptor.
>+ * Note: the supplied function should hold all the descriptors
>+ * for supported speeds
>+ */

Didn't we aggree on not adding the same kerneldoc to function's
prototype and the actual function? Please add it only to the function's
implemention.

>+int config_ep_by_speed(struct usb_gadget *g, struct usb_function *f,
>+			struct usb_ep *_ep);
>+

Sebastian