From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd Date: Tue, 24 May 2011 13:33:26 +0300 Message-ID: <20110524103325.GC14371@legolas.emea.dhcp.ti.com> References: <00ed01cc19d6$e1fef520$a5fcdf60$@org> <20110524101817.GB14371@legolas.emea.dhcp.ti.com> <010501cc19fd$b8738320$295a8960$@org> Reply-To: balbi-l0cyMroinI0@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="R+My9LyyhiUvIEro" Return-path: Content-Disposition: inline In-Reply-To: <010501cc19fd$b8738320$295a8960$@org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tanya Brokhman Cc: balbi-l0cyMroinI0@public.gmane.org, 'Alan Stern' , 'Sarah Sharp' , greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ablay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, 'open list' List-Id: linux-arm-msm@vger.kernel.org --R+My9LyyhiUvIEro Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, May 24, 2011 at 01:31:14PM +0300, Tanya Brokhman wrote: > > but then again, maybe you changed driver->speed > > to super and didn't provide superspeed descriptors. > >=20 >=20 > Yes :) The driver->speed is updated in usb_composite_probe() if > CONFIG_USB_GADGET_SUPERSPEED is defined. >=20 > So, are we ok with this solution? The module parameter I mean? > Are you going to try the v13 in your branch? Please let me know how it go= es > and of course if you have any comments. I think it still gives the possibility for failure. I would rather not take that until all gadget drivers are fixed. We can help you doing that and we only change driver->speed after all gadget drivers have their "sensible defaults" SuperSpeed descriptors. What do you say ? Other than that, the module parameter is, like Alan Said, useful for debugging, so we might as well keep it. --=20 balbi --R+My9LyyhiUvIEro Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJN24l1AAoJEAv8Txj19kN17xYH/2sfevZxOkno7F1wcYEjlEPP x/BiOjjRdhNtKbljLXDOK5LgI9h9jp7GB1uUUNod7HgPBhIQSqgFUZWOJcRNsQXq uBHe8eQFOHu/HvGaLcMAboBjB5MCZLSpRS8OY/jk3jJG7d14UQfFXPstxf70NRBW mfr1oZIX2bmu38buB4Joq1n8R+omdUKOH5b8l+2+xd4l7XJiY+Uo42eoUM+SXo55 +rDxVPJLgKcOr0aJG+UUgIk/5Jirlp2Nj2LTCcWQSHSe3qXfhMsT/NvDm+dc5zBV SfST7ZsfClCxvK3gh7GCbsoHKWa9tYSOJfYzdgawSvN/xZOWeylOG9HcovalXbw= =6pZA -----END PGP SIGNATURE----- --R+My9LyyhiUvIEro-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html