Re: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]

Hi,

On Tue, Jun 07, 2011 at 09:47:59PM +0300, Tanya Brokhman wrote:
> > > I'm not talking about dummy_hcd. It was a general comment about the
> > gadget
> > > code. I can't give you an example from the top of my head...
> > 
> > Oh.  Well, if you're writing new code and you come across a place where
> > an error message really is needed, you should add the error message.
> 
> Ok, I'll take that into consideration. Since I'm new here I was "afraid" to
> add any changes that are not really required :)

just remember to put unrelated changes on separate patches ;-)

> > But if the parameters are contradictory, you don't know _how_ to fix
> > it.  If is_super_speed is True and is_high_speed is False, did the user
> > want to add SuperSpeed support or to remove high-speed support?
> > 
> > Besides, the best (i.e., easiest and most likely to be correct) way of
> > fixing the error is for the user to issue the modprobe command again,
> > with the correct parameters this time.  Therefore the driver should
> > fail to load, so that the modprobe can be reissued with no need to do
> > rmmod first.
> > 
> 
> Ok, agreed. I'll update the patch.

Cool, I'll wait for a revised series.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]