From: Samuel Ortiz <sameo@linux.intel.com>
To: Bryan Huntsman <bryanh@codeaurora.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Anirudh Ghayal <aghayal@codeaurora.org>,
tsoni@codeaurora.org, David Brown <davidb@codeaurora.org>,
rtc-linux@googlegroups.com, Stephen Boyd <sboyd@codeaurora.org>,
linux-arm-msm@vger.kernel.org, Wan ZongShun <mcuos.com@gmail.com>,
Ashay Jaiswal <ashayj@codeaurora.org>
Subject: Re: [rtc-linux] [PATCH V4] drivers: rtc: Add support for Qualcomm PMIC8xxx RTC
Date: Wed, 8 Jun 2011 11:11:05 +0200 [thread overview]
Message-ID: <20110608091105.GI2880@sortiz-mobl> (raw)
In-Reply-To: <4DEEE0EA.9040401@codeaurora.org>
Hi Bryan,
On Tue, Jun 07, 2011 at 07:39:38PM -0700, Bryan Huntsman wrote:
> On 06/07/2011 05:32 PM, Andrew Morton wrote:
> > On Fri, 27 May 2011 10:26:18 +0530
> > Anirudh Ghayal <aghayal@codeaurora.org> wrote:
> >
> >> This patch adds support for PMIC8xxx based RTC.
> >> PMIC8xxx is Qualcomm's power management IC that
> >> internally houses an RTC module. This driver
> >> communicates with the PMIC module over SSBI bus.
> >>
> >
> > x86_64 allmodconfig:
> >
> > drivers/rtc/rtc-pm8xxx.c: In function 'pm8xxx_rtc_probe':
> > drivers/rtc/rtc-pm8xxx.c:400: error: implicit declaration of function 'mfd_get_data'
> > drivers/rtc/rtc-pm8xxx.c:400: warning: initialization makes pointer from integer without a cast
> >
> > A tree-wide grep in 3.0-rc2 for "mfd_get_data" shows no definition,
> > although ./drivers/input/keyboard/pmic8xxx-keypad.c and
> > ./drivers/input/misc/pmic8xxx-pwrkey.c are calling it.
> >
> > What's happening here?
>
>
> Samuel, this looks like it (92d57a7) was added to your branch after the
> mfd_get_data cleanup (ba279f5).
That's right. My fault for not cathcing this.
> Trilok/Anirudh, would you please send
> Samuel a patch to clean up this compilation error? Thanks.
I have applied a couple of patches for that purpose. I still need the
pm8921-core.c changes to add the input sub devices. I am also waiting for the
GPIO patches: Grant commented on them a while ago, but I never got any update.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2011-06-08 9:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 4:56 [PATCH V4] drivers: rtc: Add support for Qualcomm PMIC8xxx RTC Anirudh Ghayal
2011-05-27 5:05 ` Anirudh Ghayal
2011-06-01 3:58 ` Anirudh Ghayal
2011-06-01 8:47 ` Samuel Ortiz
2011-06-01 8:52 ` Samuel Ortiz
2011-06-01 9:22 ` Wan ZongShun
2011-06-08 0:32 ` [rtc-linux] " Andrew Morton
2011-06-08 2:39 ` Bryan Huntsman
2011-06-08 9:11 ` Samuel Ortiz [this message]
2011-06-08 9:47 ` Anirudh Ghayal
2011-06-09 4:58 ` [PATCH V1] drivers: rtc: Do not use mfd_get_data Anirudh Ghayal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110608091105.GI2880@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=aghayal@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=ashayj@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mcuos.com@gmail.com \
--cc=rtc-linux@googlegroups.com \
--cc=sboyd@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).