From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Ortiz Subject: Re: [rtc-linux] [PATCH V4] drivers: rtc: Add support for Qualcomm PMIC8xxx RTC Date: Wed, 8 Jun 2011 11:11:05 +0200 Message-ID: <20110608091105.GI2880@sortiz-mobl> References: <1306472178-22315-1-git-send-email-aghayal@codeaurora.org> <20110607173227.953bf25c.akpm@linux-foundation.org> <4DEEE0EA.9040401@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga02.intel.com ([134.134.136.20]:38934 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752429Ab1FHJLK (ORCPT ); Wed, 8 Jun 2011 05:11:10 -0400 Content-Disposition: inline In-Reply-To: <4DEEE0EA.9040401@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bryan Huntsman Cc: Andrew Morton , Anirudh Ghayal , tsoni@codeaurora.org, David Brown , rtc-linux@googlegroups.com, Stephen Boyd , linux-arm-msm@vger.kernel.org, Wan ZongShun , Ashay Jaiswal Hi Bryan, On Tue, Jun 07, 2011 at 07:39:38PM -0700, Bryan Huntsman wrote: > On 06/07/2011 05:32 PM, Andrew Morton wrote: > > On Fri, 27 May 2011 10:26:18 +0530 > > Anirudh Ghayal wrote: > > > >> This patch adds support for PMIC8xxx based RTC. > >> PMIC8xxx is Qualcomm's power management IC that > >> internally houses an RTC module. This driver > >> communicates with the PMIC module over SSBI bus. > >> > > > > x86_64 allmodconfig: > > > > drivers/rtc/rtc-pm8xxx.c: In function 'pm8xxx_rtc_probe': > > drivers/rtc/rtc-pm8xxx.c:400: error: implicit declaration of function 'mfd_get_data' > > drivers/rtc/rtc-pm8xxx.c:400: warning: initialization makes pointer from integer without a cast > > > > A tree-wide grep in 3.0-rc2 for "mfd_get_data" shows no definition, > > although ./drivers/input/keyboard/pmic8xxx-keypad.c and > > ./drivers/input/misc/pmic8xxx-pwrkey.c are calling it. > > > > What's happening here? > > > Samuel, this looks like it (92d57a7) was added to your branch after the > mfd_get_data cleanup (ba279f5). That's right. My fault for not cathcing this. > Trilok/Anirudh, would you please send > Samuel a patch to clean up this compilation error? Thanks. I have applied a couple of patches for that purpose. I still need the pm8921-core.c changes to add the input sub devices. I am also waiting for the GPIO patches: Grant commented on them a while ago, but I never got any update. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/