From: David Brown <davidb@codeaurora.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: MSM's mach/system.h
Date: Sat, 7 Jan 2012 11:08:52 -0800 [thread overview]
Message-ID: <20120107190851.GB19216@codeaurora.org> (raw)
In-Reply-To: <20120107105950.GD13857@n2100.arm.linux.org.uk>
On Sat, Jan 07, 2012 at 10:59:51AM +0000, Russell King - ARM Linux wrote:
> Guys,
>
> MSM's mach/system.h is now almost empty, except for this:
>
> extern void (*msm_hw_reset_hook)(void);
>
> Grepping around for this, I find only one place where it's called, and
> nowhere it's set:
>
> $ grep -r msm_hw_reset_hook arch/arm/*msm* drivers/
> arch/arm/mach-msm/include/mach/system.h:extern void (*msm_hw_reset_hook)(void);
> arch/arm/mach-msm/smd.c:void (*msm_hw_reset_hook)(void);
> arch/arm/mach-msm/smd.c: if (msm_hw_reset_hook)
> arch/arm/mach-msm/smd.c: msm_hw_reset_hook();
Also somewhat disturbing that the hook is declared again in the smd.c
driver, so the declaration in mach/system.h isn't really even used.
> As we've virtually eliminated the mach/system.h include (the only
> remaining ones apart from this are the three unconverted platforms for
> the restart changes), can this declaration move to somewhere else, or
> can this read-only hook be removed?
As far as I can tell, nothing even uses it in the main Android tree.
It looks like it got copied from another arch, never filled in, and
never used for anything.
It appears that plat-s5p, and mach-s3c2410 also have an unused hook.
I can make a patch, but I'm not sure what it should be based on. Or,
feel free to remove it.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
prev parent reply other threads:[~2012-01-07 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 10:59 MSM's mach/system.h Russell King - ARM Linux
2012-01-07 19:08 ` David Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120107190851.GB19216@codeaurora.org \
--to=davidb@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).