From: Daniel Walker <dwalker@fifo99.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Nicolas Pitre <nico@fluxnic.net>,
David Brown <davidb@codeaurora.org>,
Bryan Huntsman <bryanh@codeaurora.org>,
linux-arm-msm@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] ARM: mm: truncate memory banks to fit in 4GB space for classic MMU
Date: Wed, 11 Apr 2012 10:38:50 -0700 [thread overview]
Message-ID: <20120411173849.GA8114@fifo99.com> (raw)
In-Reply-To: <20120411162730.GB24211@n2100.arm.linux.org.uk>
On Wed, Apr 11, 2012 at 05:27:30PM +0100, Russell King - ARM Linux wrote:
> Of course, what prevents us doing that conversion sanely is all the
> shite platform code doing crap stuff like this:
>
> arch/arm/mach-msm/board-halibut.c: mi->bank[0].start = PHYS_OFFSET;
> arch/arm/mach-msm/board-halibut.c: mi->bank[0].size = (101*1024*1024);
>
> which I went through everything a few years ago and eliminated all this
> crap. It's back now. Sod it, we'll stick with the current 4GiB limited
> way as long as we have platform maintainers who do this kind of crappy
> hack.
>
> While here, I propose to delete these:
>
> arch/arm/mach-msm/board-mahimahi.c: mi->bank[0].start = PHYS_OFFSET;
> arch/arm/mach-msm/board-mahimahi.c: mi->bank[0].node = PHYS_TO_NID(PHYS_OFFSET);
> arch/arm/mach-msm/board-mahimahi.c: mi->bank[0].size = (219*1024*1024);
> arch/arm/mach-msm/board-mahimahi.c: mi->bank[1].start = MSM_HIGHMEM_BASE;
> arch/arm/mach-msm/board-mahimahi.c: mi->bank[1].node = PHYS_TO_NID(MSM_HIGHMEM_BASE);
> arch/arm/mach-msm/board-mahimahi.c: mi->bank[1].size = MSM_HIGHMEM_SIZE;
> arch/arm/mach-msm/board-sapphire.c: mi->bank[0].start = PHYS_OFFSET;
> arch/arm/mach-msm/board-sapphire.c: mi->bank[0].node = PHYS_TO_NID(PHYS_OFFSET);
> arch/arm/mach-msm/board-sapphire.c: mi->bank[0].size = (84*1024*1024);
> arch/arm/mach-msm/board-sapphire.c: mi->bank[0].size = (101*1024*1024);
> arch/arm/mach-msm/board-sapphire.c: mi->bank[0].size = (101*1024*1024);
>
> because they haven't been buildable since 7th May 2010 (that's 23 months
> ago), and no one has reported any build errors with them. They're only
> receiving updates from other sweeps and nothing more. This all means no
> one is even attempting to build this code. It's pointless having
> unbuildable code in the kernel, and it's nothing more than a useless
> maintanence burden.
It can't be that hard to fix.. I'll look into cleaning it up.
Daniel
next prev parent reply other threads:[~2012-04-11 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1334154639-13869-1-git-send-email-will.deacon@arm.com>
[not found] ` <1334154639-13869-4-git-send-email-will.deacon@arm.com>
[not found] ` <alpine.LFD.2.02.1204111038130.16314@xanadu.home>
[not found] ` <20120411155232.GA24211@n2100.arm.linux.org.uk>
2012-04-11 16:27 ` [PATCH v2 3/4] ARM: mm: truncate memory banks to fit in 4GB space for classic MMU Russell King - ARM Linux
2012-04-11 17:26 ` David Brown
2012-04-11 17:38 ` Daniel Walker [this message]
2012-04-11 17:40 ` Russell King - ARM Linux
2012-04-11 18:06 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411173849.GA8114@fifo99.com \
--to=dwalker@fifo99.com \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nico@fluxnic.net \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).