From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Walker Subject: Re: [PATCH v2 3/4] ARM: mm: truncate memory banks to fit in 4GB space for classic MMU Date: Wed, 11 Apr 2012 11:06:34 -0700 Message-ID: <20120411180634.GC8114@fifo99.com> References: <1334154639-13869-1-git-send-email-will.deacon@arm.com> <1334154639-13869-4-git-send-email-will.deacon@arm.com> <20120411155232.GA24211@n2100.arm.linux.org.uk> <20120411162730.GB24211@n2100.arm.linux.org.uk> <20120411173849.GA8114@fifo99.com> <20120411174024.GC24211@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from fifo99.com ([67.223.236.141]:57030 "EHLO fifo99.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756753Ab2DKSGi (ORCPT ); Wed, 11 Apr 2012 14:06:38 -0400 Content-Disposition: inline In-Reply-To: <20120411174024.GC24211@n2100.arm.linux.org.uk> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Russell King - ARM Linux Cc: Nicolas Pitre , David Brown , Bryan Huntsman , linux-arm-msm@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org On Wed, Apr 11, 2012 at 06:40:24PM +0100, Russell King - ARM Linux wrote: > On Wed, Apr 11, 2012 at 10:38:50AM -0700, Daniel Walker wrote: > > On Wed, Apr 11, 2012 at 05:27:30PM +0100, Russell King - ARM Linux wrote: > > > While here, I propose to delete these: > > > > > > arch/arm/mach-msm/board-mahimahi.c: mi->bank[0].start = PHYS_OFFSET; > > > arch/arm/mach-msm/board-mahimahi.c: mi->bank[0].node = PHYS_TO_NID(PHYS_OFFSET); > > > arch/arm/mach-msm/board-mahimahi.c: mi->bank[0].size = (219*1024*1024); > > > arch/arm/mach-msm/board-mahimahi.c: mi->bank[1].start = MSM_HIGHMEM_BASE; > > > arch/arm/mach-msm/board-mahimahi.c: mi->bank[1].node = PHYS_TO_NID(MSM_HIGHMEM_BASE); > > > arch/arm/mach-msm/board-mahimahi.c: mi->bank[1].size = MSM_HIGHMEM_SIZE; > > > arch/arm/mach-msm/board-sapphire.c: mi->bank[0].start = PHYS_OFFSET; > > > arch/arm/mach-msm/board-sapphire.c: mi->bank[0].node = PHYS_TO_NID(PHYS_OFFSET); > > > arch/arm/mach-msm/board-sapphire.c: mi->bank[0].size = (84*1024*1024); > > > arch/arm/mach-msm/board-sapphire.c: mi->bank[0].size = (101*1024*1024); > > > arch/arm/mach-msm/board-sapphire.c: mi->bank[0].size = (101*1024*1024); > > > > > > because they haven't been buildable since 7th May 2010 (that's 23 months > > > ago), and no one has reported any build errors with them. They're only > > > receiving updates from other sweeps and nothing more. This all means no > > > one is even attempting to build this code. It's pointless having > > > unbuildable code in the kernel, and it's nothing more than a useless > > > maintanence burden. > > > > > > It can't be that hard to fix.. I'll look into cleaning it up. > > What's the point of fixing code which isn't being used by anyone? As I > said above, it's a maintanence burden and if its not being used it needs > to be removed. > Aren't there whole are sub-architectures that don't even build ? I think something that's a work in progress is fine, as long as someone (i.e. me) plans to get back to it at some point. I also said that _I_ would make it build .. So someone is going to use it, and it is going to build. Daniel