From: David Brown <davidb@codeaurora.org>
To: Daniel Walker <dwalker@fifo99.com>
Cc: David Howells <dhowells@redhat.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: msm: trout: fix compile failure
Date: Fri, 13 Apr 2012 10:22:01 -0700 [thread overview]
Message-ID: <20120413172201.GA16754@codeaurora.org> (raw)
In-Reply-To: <20120413171619.GA16731@fifo99.com>
On Fri, Apr 13, 2012 at 10:16:19AM -0700, Daniel Walker wrote:
> On Thu, Apr 12, 2012 at 08:45:37AM -0700, Daniel Walker wrote:
> > Fixes the following warnings,
> >
> > arch/arm/mach-msm/board-trout.c: In function 'trout_init':
> > arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function)
> > arch/arm/mach-msm/board-trout.c:71: error: (Each undeclared identifier is reported only once
> > arch/arm/mach-msm/board-trout.c:71: error: for each function it appears in.)
> >
> > and
> >
> > arch/arm/mach-msm/board-trout-panel.c: In function 'trout_init_panel':
> > arch/arm/mach-msm/board-trout-panel.c:267: error: 'system_rev' undeclared (first use in this function)
> > arch/arm/mach-msm/board-trout-panel.c:267: error: (Each undeclared identifier is reported only once
> > arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.)
> >
>
> This needs to go upstream ASAP ..
I was going to send out a pull request today.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-04-13 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 15:45 [PATCH] arm: msm: trout: fix compile failure Daniel Walker
2012-04-13 17:16 ` Daniel Walker
2012-04-13 17:22 ` David Brown [this message]
2012-04-16 8:35 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413172201.GA16754@codeaurora.org \
--to=davidb@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=dhowells@redhat.com \
--cc=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).