From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 1/2] ARM: config: sort select statements alphanumerically Date: Fri, 12 Oct 2012 15:41:20 +0100 Message-ID: <20121012144119.GM28061@n2100.arm.linux.org.uk> References: <20121012132553.GK28061@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Linus Walleij Cc: linux-sh@vger.kernel.org, Tony Lindgren , Nicolas Ferre , Daniel Walker , Kevin Hilman , linux-samsung-soc@vger.kernel.org, Srinidhi Kasagar , Magnus Damm , David Brown , Jean-Christophe Plagniol-Villard , Alessandro Rubini , Stephen Warren , linux-arm-msm@vger.kernel.org, spear-devel@list.st.com, Sekhar Nori , Shiraz Hashim , Kukjin Kim , Haojian Zhuang , Ben Dooks , Barry Song , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Andrew Victor , linux-arm-kernel@lists.infradead.org, davinci-linux-open List-Id: linux-arm-msm@vger.kernel.org On Fri, Oct 12, 2012 at 04:04:28PM +0200, Linus Walleij wrote: > On Fri, Oct 12, 2012 at 3:26 PM, Russell King > wrote: > > > As suggested by Andrew Morton: > > > > This is a pet peeve of mine. Any time there's a long list of items > > (header file inclusions, kconfig entries, array initalisers, etc) and > > someone wants to add a new item, they *always* go and stick it at the > > end of the list. > > > > Guys, don't do this. Either put the new item into a randomly-chosen > > position or, probably better, alphanumerically sort the list. > > > > lets sort all our select statements alphanumerically. This commit was > > created by the following perl: > > I applied this and tried to configure the Nomadik defconfig, > and I get this, sadly: Yes, I've just fixed those. Unfortunately, the patch is soo large that it trips the mailing list size limit, and has to be manually approved, so I'm not sure I can call on the list maintainers again today to do the approval thing.