From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-sh@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Daniel Walker <dwalker@fifo99.com>, Kevin Hilman <khilman@ti.com>,
linux-samsung-soc@vger.kernel.org,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Magnus Damm <magnus.damm@gmail.com>,
David Brown <davidb@codeaurora.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Alessandro Rubini <rubini@unipv.it>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-arm-msm@vger.kernel.org, spear-devel@list.st.com,
Sekhar Nori <nsekhar@ti.com>,
Shiraz Hashim <shiraz.hashim@st.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Ben Dooks <ben-linux@fluff.org>, Barry Song <baohua.song@csr.com>,
linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
Andrew Victor <linux@maxim.org.za>,
linux-arm-kernel@lists.infradead.org, davinci-li
Subject: Re: [PATCH 1/2] ARM: config: sort select statements alphanumerically
Date: Fri, 12 Oct 2012 08:09:47 -0700 [thread overview]
Message-ID: <20121012150945.GB30339@atomide.com> (raw)
In-Reply-To: <20121012144119.GM28061@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [121012 07:44]:
> On Fri, Oct 12, 2012 at 04:04:28PM +0200, Linus Walleij wrote:
> > On Fri, Oct 12, 2012 at 3:26 PM, Russell King
> > <rmk+kernel@arm.linux.org.uk> wrote:
> >
> > > As suggested by Andrew Morton:
> > >
> > > This is a pet peeve of mine. Any time there's a long list of items
> > > (header file inclusions, kconfig entries, array initalisers, etc) and
> > > someone wants to add a new item, they *always* go and stick it at the
> > > end of the list.
> > >
> > > Guys, don't do this. Either put the new item into a randomly-chosen
> > > position or, probably better, alphanumerically sort the list.
> > >
> > > lets sort all our select statements alphanumerically. This commit was
> > > created by the following perl:
> >
> > I applied this and tried to configure the Nomadik defconfig,
> > and I get this, sadly:
>
> Yes, I've just fixed those. Unfortunately, the patch is soo large that
> it trips the mailing list size limit, and has to be manually approved,
> so I'm not sure I can call on the list maintainers again today to do the
> approval thing.
After applying these two patches and manually running:
$ git checkout-index -f arch/arm/mach-pxa/Kconfig
$ git checkout-index -f arch/arm/mach-footbridge/Kconfig
It builds just fine for omaps, so for omaps:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2012-10-12 15:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 13:25 [PATCH 0/2] ARM: sort configuration files Russell King - ARM Linux
2012-10-12 13:26 ` [PATCH 2/2] ARM: config: make sure that platforms are ordered by option string Russell King
[not found] ` <20121012132553.GK28061-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-10-12 13:26 ` [PATCH 1/2] ARM: config: sort select statements alphanumerically Russell King
2012-10-12 14:04 ` Linus Walleij
2012-10-12 14:41 ` Russell King - ARM Linux
2012-10-12 14:48 ` Russell King - ARM Linux
2012-10-12 15:01 ` Stephen Warren
[not found] ` <20121012144832.GN28061-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-10-12 18:14 ` Linus Walleij
2012-10-13 14:56 ` Sekhar Nori
2012-10-12 15:09 ` Tony Lindgren [this message]
2012-10-16 2:15 ` Eric Miao
2012-10-12 14:08 ` Jason Cooper
2012-10-12 13:32 ` [PATCH 0/2] ARM: sort configuration files Russell King - ARM Linux
2012-10-13 16:42 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012150945.GB30339@atomide.com \
--to=tony@atomide.com \
--cc=baohua.song@csr.com \
--cc=ben-linux@fluff.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=haojian.zhuang@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=khilman@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@maxim.org.za \
--cc=magnus.damm@gmail.com \
--cc=nicolas.ferre@atmel.com \
--cc=nsekhar@ti.com \
--cc=plagnioj@jcrosoft.com \
--cc=rubini@unipv.it \
--cc=shiraz.hashim@st.com \
--cc=spear-devel@list.st.com \
--cc=srinidhi.kasagar@stericsson.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).