From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCHv2] arm: mm: Use phys_addr_t properly for ioremap functions
Date: Wed, 15 May 2013 16:15:39 +0200
Message-ID: <201305151615.39752.arnd@arndb.de>
References: <1368560031-19367-1-git-send-email-lauraa@codeaurora.org>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from moutng.kundenserver.de ([212.227.126.186]:65142 "EHLO
	moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756609Ab3EOOPn (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Wed, 15 May 2013 10:15:43 -0400
In-Reply-To: <1368560031-19367-1-git-send-email-lauraa@codeaurora.org>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Laura Abbott <lauraa@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org, Russell King <linux@arm.linux.org.uk>, Will Deacon <will.deacon@arm.com>, linux-arm-msm@vger.kernel.org, Krzysztof Halasa <khc@pm.waw.pl>, Stephen Boyd <sboyd@codeaurora.org>

On Tuesday 14 May 2013, Laura Abbott wrote:
> Several of the ioremap functions use unsigned long in places
> resulting in truncation if physical addresses greater than
> 4G are passed in. Change the types of the functions and the
> callers accordingly.

Looks good to me. I wonder a bit whether resource_size_t or phys_addr_t
is the right type here, but they are always defined to the same type
these days.

FWIW, x86 and tile use resource_size_t, while a couple of other architectures
use phys_addr_t.

	Arnd