From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCHv2 2/2] mfd: ssbi: Use devm_* and simplify code Date: Tue, 4 Jun 2013 08:33:35 +0100 Message-ID: <20130604073335.GK3370@gmail.com> References: <1370288384-3122-1-git-send-email-sboyd@codeaurora.org> <1370288384-3122-2-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wg0-f45.google.com ([74.125.82.45]:56447 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759317Ab3FDHdk (ORCPT ); Tue, 4 Jun 2013 03:33:40 -0400 Received: by mail-wg0-f45.google.com with SMTP id n12so3975969wgh.0 for ; Tue, 04 Jun 2013 00:33:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1370288384-3122-2-git-send-email-sboyd@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Samuel Ortiz , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, David Brown On Mon, 03 Jun 2013, Stephen Boyd wrote: > Use devm_ioremap_resource and devm_kzalloc to simplify error > paths and reduce lines of code. Also use dev_err() to keep > consistency and drop the .remove function because the devm > functions take care of what it's doing besides the now obsolete > platform_set_drvdata() which we can just drop. Finally, use > module_platform_driver() to save some more lines. >=20 > Cc: David Brown > Signed-off-by: Stephen Boyd > --- Really nice. Acked-by: Lee Jones --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog