From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET Date: Thu, 25 Jul 2013 23:54:48 +0300 Message-ID: <20130725205448.GA12343@radagast> References: <20130725184651.GA15259@kroah.com> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:43900 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752713Ab3GYUy6 (ORCPT ); Thu, 25 Jul 2013 16:54:58 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Alan Stern Cc: Greg KH , Jack Pham , linux-usb@vger.kernel.org, Tim Sander , Manu Gautam , linux-arm-msm@vger.kernel.org --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote: > On Thu, 25 Jul 2013, Greg KH wrote: >=20 > > On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > > > From: Manu Gautam > > >=20 > > > The USB Embedded High-speed Host Electrical Test (EHSET) defines the > > > SINGLE_STEP_SET_FEATURE test as follows: > > >=20 > > > 1) The host enumerates the test device with VID:0x1A0A, PID:0x0108 > > > 2) The host sends the SETUP stage of a GetDescriptor(Device) > > > 3) The device ACKs the request > > > 4) The host issues SOFs for 15 seconds allowing the test operator to > > > raise the scope trigger just above the SOF voltage level > > > 5) The host sends the IN packet > > > 6) The device sends data in response, triggering the scope > > > 7) The host sends an ACK in response to the data > > >=20 > > > This patch adds additional handling to the EHCI hub driver and allows > > > the EHSET driver to initiate this test mode by issuing a a SetFeature > > > request to the root hub with a Test Selector value of 0x06. From there > > > it mimics ehci_urb_enqueue() but separately submits QTDs for the > > > SETUP and DATA/STATUS stages in order to insert a delay in between. > > >=20 > > > Signed-off-by: Manu Gautam > > > Signed-off-by: Jack Pham > >=20 > > Alan, any thoughts about this patch? >=20 > Sorry, this slipped my mind. >=20 > It looks okay. I haven't tested it yet (and it's so specialized that > it probably will never receive very much testing). It is somewhat=20 > fragile, in that it copies part of usbcore into ehci-hcd; updates to=20 > the core will have to be mirrored in the driver. >=20 > On the other hand, there's no real reason to reject it, and it could=20 > end up helping people who want to test new USB devices. So... >=20 > Acked-by: Alan Stern Wait a minute, didn't we discuss a while back that these test features should be built into usbcore so that we could have a usbcv clone for linux ? --=20 balbi --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJR8ZCYAAoJEIaOsuA1yqRElR0P/3o0eSNM8VkPadLCxzrXLkq+ exQ1qJnQgzUf3AVvo6iGkDvk86WMAQ6LYS63R5XMSVwgH4eUK1iIMYWBYtiIzNli CBiGsRz9ZzCtxj+BfFu0uEpXb68l0VuFqgwkR9GYQ8jlJwGiHr4qD/MawrALRmWR 0j0WaMdNRH+qHN9XDP+10++6TbztB6AG5eMEk6UH9j682BaIfRuqS6V3FyFK4gij By9f1B92US98ON92R2Bx1e3Q7Tc477uK9br8vpAFU8hZn8hzVf6cIdLFvbTwlJ0J NtsodkMeUCkqZUbWXYB5alpG2VQsVzFd/o7TUbYT/BUS3gx9mxansg1ULuMJGSVZ 2LMVqJekQu/Z/WRK6aVnvYq9bXO9JR6DF2dvZLLQzxjGejP1BR76LBOdf/uUmLSq 9JeN03r4b4fP0/lf6bw5l2afU9muGvLWbcLO3aaEe4LRO03nLbZQmLT2Oxq2oJbA J1jz6yDDfdrd+3Av928rETDjPuCBHqS+R6xXpHoSg1pvOI+1DXEKyWp9NntMLIlM 3cvqwek6+dl5ILd4saSObROilKS+uTMD0t77dD4O3E7nZZ4Tz2Uyqb1SJYpAKWuz +udw+5f2knJFDnPqii4XNMR3hu4O7zjaEXDaB+bimiQ9XjnYsMGD+reWoxpe98Ac 2aEWVWV1VSUqz0MkAykn =FDds -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--