From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET Date: Fri, 9 Aug 2013 16:41:24 +0300 Message-ID: <20130809134124.GL12041@radagast> References: <20130725205448.GA12343@radagast> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hdW7zL/qDS6RXdAL" Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:40938 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752154Ab3HINll (ORCPT ); Fri, 9 Aug 2013 09:41:41 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Alan Stern Cc: Felipe Balbi , Greg KH , Jack Pham , linux-usb@vger.kernel.org, Tim Sander , Manu Gautam , linux-arm-msm@vger.kernel.org --hdW7zL/qDS6RXdAL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Jul 25, 2013 at 05:33:48PM -0400, Alan Stern wrote: > > On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote: > > > On Thu, 25 Jul 2013, Greg KH wrote: > > >=20 > > > > On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > > > > > From: Manu Gautam > > > > >=20 > > > > > The USB Embedded High-speed Host Electrical Test (EHSET) defines = the > > > > > SINGLE_STEP_SET_FEATURE test as follows: > > > > >=20 > > > > > 1) The host enumerates the test device with VID:0x1A0A, PID:0x0108 > > > > > 2) The host sends the SETUP stage of a GetDescriptor(Device) > > > > > 3) The device ACKs the request > > > > > 4) The host issues SOFs for 15 seconds allowing the test operator= to > > > > > raise the scope trigger just above the SOF voltage level > > > > > 5) The host sends the IN packet > > > > > 6) The device sends data in response, triggering the scope > > > > > 7) The host sends an ACK in response to the data > > > > >=20 > > > > > This patch adds additional handling to the EHCI hub driver and al= lows > > > > > the EHSET driver to initiate this test mode by issuing a a SetFea= ture > > > > > request to the root hub with a Test Selector value of 0x06. From = there > > > > > it mimics ehci_urb_enqueue() but separately submits QTDs for the > > > > > SETUP and DATA/STATUS stages in order to insert a delay in betwee= n. > > > > >=20 > > > > > Signed-off-by: Manu Gautam > > > > > Signed-off-by: Jack Pham > > > >=20 > > > > Alan, any thoughts about this patch? > > >=20 > > > Sorry, this slipped my mind. > > >=20 > > > It looks okay. I haven't tested it yet (and it's so specialized that > > > it probably will never receive very much testing). It is somewhat=20 > > > fragile, in that it copies part of usbcore into ehci-hcd; updates to= =20 > > > the core will have to be mirrored in the driver. > > >=20 > > > On the other hand, there's no real reason to reject it, and it could= =20 > > > end up helping people who want to test new USB devices. So... > > >=20 > > > Acked-by: Alan Stern > >=20 > > Wait a minute, didn't we discuss a while back that these test features > > should be built into usbcore so that we could have a usbcv clone for > > linux ? >=20 > There's no way this can be built into the core. This test requires the > behavior of the host controller to be modified at a low level > (introducing a 15-second delay between the Setup and Data stages of a > control transfer). Only the HCD can do that. heh, it doesn't need to be entirely in the core. Core could have the generic calls and HCDs could implement some callbacks, but I think quite a bit of the code will be similar if we implement the same thing on all HCDs. > Besides, doesn't USB-CV install its own version of Windows' EHCI driver= =20 > while it runs its tests? IIRC only USB20CV, the new USB30CV (which also tests USB2) doesn't do that. --=20 balbi --hdW7zL/qDS6RXdAL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJSBPGEAAoJEIaOsuA1yqRE/4IP/0bMNsRFxThvUAWi1lvnTLfZ sn+XSc1f1JMg3JOdw/bEoiC4YhRA00jvtx/OKSnqW6HILGpIVbKtSCUtwCKvL1vZ vvz2+y/GseH6qKbuc1SNilsqFarKftp9Ka7Uxz1QSA5vShr6r+0k/tMdDYQiMlZH rxTHVffhxjHh5hrlf7ZKFIyffnW3RnepNAeIbd0RPjcMZdwDH7PfRgfSTN5OM81o 57rPOpi+nIK2s+Z6DmkQ+VorLa7lxXe+0EaEUmUuPoG1fPvPvFyqjVVR6Hcsjxke 1bmLAYZtLj83HPjKMTne7zjez0KSUtsouD1JDkDVK2FbkGRviDF7nrjoYCdJbpkZ OPMnX9W945O4xtBWfukkQrI2OYTObUzDwkfieOsPnGuJU4TWKzlr2Xi6s8T34ApW Qer+Y3wPv11OnTc44yfVOhiDqBGjvm94BbWXIXF7Lazt2Xeo/4WfG3VSwGiL3Ba+ HFXzorGrmafoAS6r9Rq8DXXF6lGKa2im5l7PhYMqAKHxpTUS/yJaQWxTmww/rU41 ovV1HnZSPJPReHQJslyVdwWIJ8eNWvQsyY+cxGGQlzrBrrXpxi0hl3T2UMYNKh1E tubfBBikisyrjhBxYHXluBYJoF9dEbghImEp9S1sQY1M298+GlJLgj8IhGUPu8/c KKpMVK4FUIJ6LbPHYVR2 =lkUQ -----END PGP SIGNATURE----- --hdW7zL/qDS6RXdAL--