From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET Date: Mon, 12 Aug 2013 12:53:56 -0500 Message-ID: <20130812175356.GA27954@radagast> References: <20130809144452.GR12041@radagast> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alan Stern Cc: Felipe Balbi , Greg KH , Jack Pham , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tim Sander , Manu Gautam , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Aug 09, 2013 at 11:04:48AM -0400, Alan Stern wrote: > > > > heh, it doesn't need to be entirely in the core. Core could have the > > > > generic calls and HCDs could implement some callbacks, but I think = quite > > > > a bit of the code will be similar if we implement the same thing on= all > > > > HCDs. > > >=20 > > > What generic calls and callbacks would you suggest? I assume you wan= t=20 > > > enough to cover not just this one test but the entire USB-CV suite. > >=20 > > maybe a single callback for supporting 'testmodes' ? which receives the > > test mode as argument ? >=20 > I don't have a clear picture of how you would apply such an approach to= =20 > this case. There would have to be a way to tell the HCD to insert a > 15-second delay between the Setup and Data stages of a particular > control URB. How would you do that? Whatever method you choose, each test is started after enumerating a known Vid/Pid pair. Based on that, you *know* which test to run. > implementing it in every HCD would be a huge amount of work. sure, we can support different HCDs with time, but once SINGLE_STEP is implemented in e.g. EHCI, it should be simple to port it to OHCI/xHCI/MUSB/etc. > What other test modes would you want to support? anything that USB[23]0CV supports today. There are even link layer tests for USB3 and a bunch of others. This SINGLE_STEP_SET_FEATURE is but one of a large(-ish) test suite which needs to be supported. > Is it worth adding this support to the standard host controller > drivers, or should there be a special version (a Kconfig option like > CONFIG_RCU_TORTURE_TEST) to enable it? Putting a lot of testing code > in distribution kernels where it will never be used seems like a big > waste. right, I think it should be hidden by Kconfig, not arguing against that. --=20 balbi --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJSCSE0AAoJEIaOsuA1yqRE7NUQAItKuEWRne9iRhTYZXrJVquT pJ2W1Eg2Tg7/iaw4/2TydxSi9mEj23bQEW7A0F6IOcIpHhNnTWYIkdyPCNJlXjmP 04l/V2mk7Ce7dJBh69o2jgAoidmKwN6xB0ykssFVeSWUdjP4itClENVoHonVWhQn Ako4cz5OWxQOYmRJPjQU80Vj2Lpw20GvvoQLYundze7rkdWqDlqMP5eyV9wFXsnI pvhoy7/tVfz4kY5E1nepFgx3v2eAjTPNW4M2aEs0U1rpxmDIPyNQomA4r+MIodYA C+2+IYziI/5HUXMPDK7OSx8iTz/Cs3JJMzxFBB/vup1si5a7n5V+6EdtWu55vww5 WMRr/cRjTvn8YLmnCDQ+kZRPFJoCdgTR+b6xJuqbiOSdJlZVBmUS6vuu9y+NKec2 HBvwFQS5tQuqCFTTsgeK494y26y0l6Op2106MR2pnDCyXp2NKoiUclDbqRHbIFM5 OZ2pRO2ySu17wbOF5+H3SW4sEVTfe7DC1qMb9KCTZSNA5r2DQmI/VodEmpzby4Fu KX4Jss13kWR1SXD7PkY70W4mX7YLNEWvQipP25o1AE0QcHYtqEinHGWnVOLVJ9VS pKbI2fleB0ey2mRUiZ9Ir5mKwqSq/A+K0c3958Aj9+B1+Q1WO8boacr/nrY9RcnY 1YtfqNWrIlFhB2wOU0Wk =Mbnl -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html