From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brown Subject: Re: [BUG] mach-msm/msm_vibrator.c - very long vibration if CPU suspends Date: Wed, 11 Sep 2013 12:47:20 -0700 Message-ID: <20130911194720.GA2818@codeaurora.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:40187 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752939Ab3IKTrX (ORCPT ); Wed, 11 Sep 2013 15:47:23 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: abhilash jindal Cc: linux-arm-msm , dwalker@codeaurora.org, bryanh@codeaurora.org On Wed, Sep 04, 2013 at 05:24:50PM -0400, abhilash jindal wrote: >msm_vibrator.c uses hrtimer to switch off the phone vibration as follows- > >hrtimer_start(&vibe_timer, ktime_set(value / 1000, (value % 1000) * >1000000), HRTIMER_MODE_REL); > >However, hrtimer does not get fired after the CPU suspends. Hence, if >the CPU suspends before the timer gets fired, the phone continues >vibrating until the next time when CPU wakes up causing unnecessary >battery drain (which can be as long as 15 minutes). > >IMHO, one way to fix it would be to replace hrtimer by android alarm timer. It looks like this file exists only in the codeaurora.org MSM tree, and not in the mainline kernel. The first thing I'd mention is that if you are an MSM customer, you'll be much better off reporting this through the customer support chain. Otherwise, I can forward this information internally. I'm not sure if they'll be any response, since it doesn't appear to be used in any recent targets. David -- sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation