Re: [PATCH v6 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's

[Mark Rutland <mark.rutland@arm.com>]

[...]

> > > +   phy->sleep_a_clk = devm_clk_get(phy->dev, "sleep_a");
> >
> > What means the "_a" in clock name?
> 
> They are 2 PHY's on 8074 chip. This drivers is supposed to
> operate on PHY 0, thus sleep_a. PHY 1 is using sleep_b. Take a look
> here http://www.spinics.net/lists/arm-kernel/msg276945.html

When you say two PHYs, do you mean the HS PHY and the SS PHY?

Or are there two HS PHYs? If so, would the other HS PHY have a sleep_b clock?

The clock-names property should describe the clocks from the view of the device
itself. As we're describing the PHY in isolation, rather than a big block that
contains the PHY, the presesnce or absence of other PHYs should not affect the
name. If the "_a" suffix is only to differentiate the instance of PHY, it
should be dropped.

Thanks,
Mark.