From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 1/7] ARM: perf_event: Silence sparse warning Date: Thu, 9 Jan 2014 10:45:20 +0000 Message-ID: <20140109104519.GA17838@mudshark.cambridge.arm.com> References: <1389221984-10973-1-git-send-email-sboyd@codeaurora.org> <1389221984-10973-2-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:42628 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbaAIKpu (ORCPT ); Thu, 9 Jan 2014 05:45:50 -0500 Content-Disposition: inline In-Reply-To: <1389221984-10973-2-git-send-email-sboyd@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Hi Stephen, On Wed, Jan 08, 2014 at 10:59:38PM +0000, Stephen Boyd wrote: > arch/arm/kernel/perf_event_cpu.c:274:25: warning: incorrect type in assignment (different modifiers) > arch/arm/kernel/perf_event_cpu.c:274:25: expected int ( *init_fn )( ... ) > arch/arm/kernel/perf_event_cpu.c:274:25: got void const *const data > > Signed-off-by: Stephen Boyd > --- Given that the rest of the series depends on the change to the percpu IRQ stuff, I think you can just send this patch to Russell's patch system with my ack: Acked-by: Will Deacon Cheers, Will > arch/arm/kernel/perf_event_cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/kernel/perf_event_cpu.c b/arch/arm/kernel/perf_event_cpu.c > index d85055cd24ba..20d553c9f5e2 100644 > --- a/arch/arm/kernel/perf_event_cpu.c > +++ b/arch/arm/kernel/perf_event_cpu.c > @@ -254,7 +254,7 @@ static int probe_current_pmu(struct arm_pmu *pmu) > static int cpu_pmu_device_probe(struct platform_device *pdev) > { > const struct of_device_id *of_id; > - int (*init_fn)(struct arm_pmu *); > + const int (*init_fn)(struct arm_pmu *); > struct device_node *node = pdev->dev.of_node; > struct arm_pmu *pmu; > int ret = -ENODEV; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > >