From: Courtney Cavin <courtney.cavin@sonymobile.com>
To: Laura Abbott <lauraa@codeaurora.org>
Cc: Russell King <linux@arm.linux.org.uk>,
David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Rob Herring <robherring2@gmail.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Will Deacon <will.deacon@arm.com>,
Nicolas Pitre <nicolas.pitre@linaro.or>
Subject: Re: [PATCHv2 2/2] arm: Get rid of meminfo
Date: Mon, 10 Feb 2014 09:28:09 -0800 [thread overview]
Message-ID: <20140210172808.GS1706@sonymobile.com> (raw)
In-Reply-To: <52F846AE.3050800@codeaurora.org>
On Mon, Feb 10, 2014 at 04:25:34AM +0100, Laura Abbott wrote:
> On 2/6/2014 6:09 PM, Courtney Cavin wrote:
> > On Wed, Feb 05, 2014 at 01:02:31AM +0100, Laura Abbott wrote:
> >> memblock is now fully integrated into the kernel and is the prefered
> >> method for tracking memory. Rather than reinvent the wheel with
> >> meminfo, migrate to using memblock directly instead of meminfo as
> >> an intermediate.
> >>
> >> Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
> > [...]
> >> diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c
> >> index 0b11c1a..51d814e 100644
> >> --- a/arch/arm/mach-pxa/spitz.c
> >> +++ b/arch/arm/mach-pxa/spitz.c
> >> @@ -32,6 +32,7 @@
> >> #include <linux/io.h>
> >> #include <linux/module.h>
> >> #include <linux/reboot.h>
> >> +#include <linux/memblock.h>
> >>
> >> #include <asm/setup.h>
> >> #include <asm/mach-types.h>
> >> @@ -971,13 +972,9 @@ static void __init spitz_init(void)
> >> spitz_i2c_init();
> >> }
> >>
> >> -static void __init spitz_fixup(struct tag *tags, char **cmdline,
> >> - struct meminfo *mi)
> >> +static void __init spitz_fixup(struct tag *tags, char **cmdline)
> >> {
> >> - sharpsl_save_param();
> >> - mi->nr_banks = 1;
> >> - mi->bank[0].start = 0xa0000000;
> >> - mi->bank[0].size = (64*1024*1024);
> >> + memblock_addr(0xa0000000, SZ_64M);
> >
> > memblock_add() ?
> Yes, that was a typo on my part. I'll send out a v3 with collected acks.
>
So, I also just noticed that you specifically remove the call to
sharpsl_save_param() here. I'm presuming that this is also an error, as
you haven't removed it from any of the other pxa fixups, and it seems
unrelated to the change.
-Courtney
next prev parent reply other threads:[~2014-02-10 17:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1391558551-31395-1-git-send-email-lauraa@codeaurora.org>
2014-02-05 0:02 ` [PATCHv2 2/2] arm: Get rid of meminfo Laura Abbott
2014-02-05 2:00 ` Jason Cooper
2014-02-05 13:43 ` Leif Lindholm
2014-02-05 23:21 ` Santosh Shilimkar
2014-02-07 2:09 ` Courtney Cavin
2014-02-10 3:25 ` Laura Abbott
2014-02-10 10:11 ` Catalin Marinas
2014-02-10 17:28 ` Courtney Cavin [this message]
2014-02-10 21:59 ` Laura Abbott
2014-02-10 21:58 ` Grant Likely
2014-02-11 9:47 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210172808.GS1706@sonymobile.com \
--to=courtney.cavin@sonymobile.com \
--cc=andrew@lunn.ch \
--cc=ard.biesheuvel@linaro.org \
--cc=ben-linux@fluff.org \
--cc=catalin.marinas@arm.com \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=eric.y.miao@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=haojian.zhuang@gmail.com \
--cc=jason@lakedaemon.net \
--cc=kgene.kim@samsung.com \
--cc=lauraa@codeaurora.org \
--cc=leif.lindholm@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.pitre@linaro.or \
--cc=robherring2@gmail.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox