From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH] usb: phy: msm: fix possible build error Date: Wed, 19 Feb 2014 13:43:40 -0600 Message-ID: <20140219194340.GA9605@saruman.home> References: <1392784558-26854-1-git-send-email-balbi@ti.com> <20140219062805.GF14769@codeaurora.org> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OgqxwSJOaUobr8KG" Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:34183 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751851AbaBSTpK (ORCPT ); Wed, 19 Feb 2014 14:45:10 -0500 Content-Disposition: inline In-Reply-To: <20140219062805.GF14769@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Felipe Balbi , "Ivan T. Ivanov" , Peter Chen , Jingoo Han , Linux USB Mailing List , Josh Cartwright , linux-arm-msm@vger.kernel.org --OgqxwSJOaUobr8KG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Feb 18, 2014 at 10:28:06PM -0800, Stephen Boyd wrote: > On 02/18, Felipe Balbi wrote: > > This will fail builds on configs where > > CONFIG_PM_RUNTIME=3Dy and CONFIG_PM_SLEEP=3Dn. > >=20 > > Following build error will show up: > >=20 > > drivers/usb/phy/phy-msm-usb.c: In function ???msm_otg_runtime_suspend?= ??: > > drivers/usb/phy/phy-msm-usb.c:1693:2: error: implicit declaration of \ > > function ???msm_otg_suspend??? [-Werror=3Dimplicit-function-declaratio= n] > > return msm_otg_suspend(motg); > > ^ > > drivers/usb/phy/phy-msm-usb.c: In function ???msm_otg_runtime_resume??= ?: > > drivers/usb/phy/phy-msm-usb.c:1701:2: error: implicit declaration of \ > > function ???msm_otg_resume??? [-Werror=3Dimplicit-function-declaration] > > return msm_otg_resume(motg); > > ^ > >=20 > > This patch fixes the error by defining msm_otg_{suspend,resume} > > whenever CONFIG_PM=3Dy. > >=20 > > Signed-off-by: Felipe Balbi >=20 > I'm lost. Didn't Josh send a patch for this to you already? >=20 > [1] https://patchwork.kernel.org/patch/3673401/ true, dropped. --=20 balbi --OgqxwSJOaUobr8KG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJTBQlsAAoJEIaOsuA1yqREVdsP/0GilRYj+jl2sY3aVDkl0CKq 2KpootzKA3t3mJGk7Koom/rvKpRK98WUrt9m2aNILqevpvPy5XRZfolMAZsQTscX ZPaB/OI1mZYmZlJaBVppihZrdbwWi5z4s2cBM3YW9q/u5xQNMasTuha35jUQnEoI L9Y86xbiAWOsn0abJgmMnrDjPhr7oUNkAQvC9rtvBi9M938SoFh3PkTCdAQoTEql oczaJYuglpIk7750DETzZdtVr30jH/9jUmcdMWlXin+djOC9E3Id+XQ3K0AJcCzy 5j8n/4FVRJAPTKT835D9IeHwb+OlN2aisitwSGJx7zEoOiHgWOwKaPC+F/CABE6s +qZsnI8a71QegvhIbQJSUoh2gKFASCVZci5stIKQ2ZBmAV81G2ck2Cq/PMjk98+U 8BjDnZevkigIlLIaRN+d2GW6PBQBXFKA/Xkkfde+fka89O4gQy8kSmJx9xiPxgaU YCf4/83ajbueueKWwbpx3X9AZ0PDNZtlLEF1/i4J72perXnF6O5qUOJKm6TkXtLn oG3ictJlXspuisuVUL/0pOkp0kphXcMijkWEHre0pVhqpbhACHtxbEPf0HgmKdPO 3t7qf0RKfYkjBZKh8RcXuppnmde1HkZcKRw0kn/jT5E3l03Y5kIWb/7Q47gT2OHx sYGur1Zs1+JkMzQYoeVN =dww9 -----END PGP SIGNATURE----- --OgqxwSJOaUobr8KG--