From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Josh Cartwright <joshc@codeaurora.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: msm: drop wake_irqs bitmap
Date: Thu, 6 Mar 2014 19:26:49 -0800 [thread overview]
Message-ID: <20140307032635.GF21801@sonymobile.com> (raw)
In-Reply-To: <1394047988-14081-1-git-send-email-joshc@codeaurora.org>
On Wed 05 Mar 11:33 PST 2014, Josh Cartwright wrote:
> Currently, the wake_irqs bitmap is used to track whether there are any
> gpio's which are configured as wake irqs, and uses this to determine
> whether or not to call enable_irq_wake()/disable_irq_wake() on the
> summary interrupt.
>
> However, the genirq core already handles this case, by maintaining a
> 'wake_count' per irq_desc, and only calling into the controlling
> irq_chip when wake_count transitions 0 <-> 1.
>
> Drop this bitmap, and unconditionally call irq_set_irq_wake() on the
> summary interrupt.
I wasn't aware of that, change looks good!
Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
next prev parent reply other threads:[~2014-03-07 3:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 19:33 [PATCH] pinctrl: msm: drop wake_irqs bitmap Josh Cartwright
2014-03-07 3:26 ` Bjorn Andersson [this message]
2014-03-12 13:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307032635.GF21801@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=joshc@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).