From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver Date: Fri, 7 Mar 2014 17:11:08 -0600 Message-ID: <20140307231108.GD3241@qualcomm.com> References: <1393828245-18766-1-git-send-email-agross@codeaurora.org> <1393828245-18766-3-git-send-email-agross@codeaurora.org> <1393839482.28803.118.camel@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:51940 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751880AbaCGXLK (ORCPT ); Fri, 7 Mar 2014 18:11:10 -0500 Content-Disposition: inline In-Reply-To: <1393839482.28803.118.camel@smile.fi.intel.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: "Shevchenko, Andriy" Cc: "Koul, Vinod" , "Williams, Dan J" , "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" On Mon, Mar 03, 2014 at 09:38:03AM +0000, Shevchenko, Andriy wrote: > > + if (IS_ERR(bdev->bamclk)) > > + return PTR_ERR(bdev->bamclk); > > + > > + ret = clk_prepare_enable(bdev->bamclk); > > + if (ret) { > > + dev_err(bdev->dev, "failed to prepare/enable clock\n"); > > + return ret; > > + } > > + > > + ret = of_property_read_u32(pdev->dev.of_node, "qcom,ee", &bdev->ee); > > + if (ret) { > > + dev_err(bdev->dev, "Execution environment unspecified\n"); > > + return ret; > > goto err_disable_clk; ? > > > > > + } > > + > > + ret = bam_init(bdev); > > + if (ret) > > + return ret; > > Ditto. > Good catch. I'll fix both of those. -- sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation