From: Felipe Balbi <balbi@ti.com>
To: Tim Bird <tbird20d@gmail.com>
Cc: iivanov@mm-sol.com, linux-arm-msm@vger.kernel.org,
galak@codeaurora.org, balbi@ti.com, davidb@codeaurora.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Tim Bird <tim.bird@sonymobile.com>
Subject: Re: [PATCH] usb: phy: msm: Select secondary PHY via TCSR
Date: Mon, 21 Apr 2014 11:14:42 -0500 [thread overview]
Message-ID: <20140421161442.GC22794@saruman.home> (raw)
In-Reply-To: <1396649891-2880-1-git-send-email-tim.bird@sonymobile.com>
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
Hi,
On Fri, Apr 04, 2014 at 03:18:11PM -0700, Tim Bird wrote:
> Select the secondary PHY using the TCSR register, if phy-num=1
> in the DTS (or phy_number is set in the platform data). The
> SOC has 2 PHYs which can be used with the OTG port, and this
> code allows configuring the correct one.
>
> Note: This resolves the problem I was seeing where I couldn't
> get the USB driver working at all on a dragonboard, from cold
> boot. This patch depends on patch 5/14 from Ivan's msm USB
> patch set. It does not use DT for the register address, as
> there's no evidence that this address changes between SoC
> versions.
>
> Signed-off-by: Tim Bird <tim.bird@sonymobile.com>
doesn't apply:
checking file drivers/usb/phy/phy-msm-usb.c
Hunk #1 succeeded at 1412 with fuzz 2 (offset -106 lines).
Hunk #2 FAILED at 1581.
1 out of 2 hunks FAILED
checking file include/linux/usb/msm_hsusb_hw.h
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-04-21 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 22:18 [PATCH] usb: phy: msm: Select secondary PHY via TCSR Tim Bird
2014-04-21 16:14 ` Felipe Balbi [this message]
2014-04-21 17:03 ` Tim Bird
2014-04-21 17:08 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140421161442.GC22794@saruman.home \
--to=balbi@ti.com \
--cc=davidb@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tbird20d@gmail.com \
--cc=tim.bird@sonymobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).