From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 1/3] usb: phy: msm: cast to unsigned long int Date: Mon, 5 May 2014 10:03:31 -0500 Message-ID: <20140505150331.GA17875@saruman.home> References: <1398875916-14461-1-git-send-email-balbi@ti.com> <1399100192.7131.2.camel@violet> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="u3/rZRmxL6MmkK24" Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:54074 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933028AbaEEPDl (ORCPT ); Mon, 5 May 2014 11:03:41 -0400 Content-Disposition: inline In-Reply-To: <1399100192.7131.2.camel@violet> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: "Ivan T. Ivanov" Cc: Felipe Balbi , tim.bird@sonymobile.com, linux-arm-msm@vger.kernel.org, Linux USB Mailing List --u3/rZRmxL6MmkK24 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 03, 2014 at 09:56:32AM +0300, Ivan T. Ivanov wrote: > On Wed, 2014-04-30 at 11:38 -0500, Felipe Balbi wrote: > > this solves the following build warning found when > > running compile tests. > >=20 > > drivers/usb/phy/phy-msm-usb.c: In function =E2=80=98msm_otg_read_dt=E2= =80=99: > > drivers/usb/phy/phy-msm-usb.c:1459:20: warning: cast from pointer \ > > to integer of different size [-Wpointer-to-int-cast] > > pdata->phy_type =3D (int) id->data; > > ^ > > Signed-off-by: Felipe Balbi > > --- > >=20 > > all patches are on top of Ivan's 20 patch series. > >=20 > > drivers/usb/phy/phy-msm-usb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-us= b.c > > index 9dc7918..c9963c8 100644 > > --- a/drivers/usb/phy/phy-msm-usb.c > > +++ b/drivers/usb/phy/phy-msm-usb.c > > @@ -1456,7 +1456,7 @@ static int msm_otg_read_dt(struct platform_device= *pdev, struct msm_otg *motg) > > motg->pdata =3D pdata; > > =20 > > id =3D of_match_device(msm_otg_dt_match, &pdev->dev); > > - pdata->phy_type =3D (int) id->data; > > + pdata->phy_type =3D (unsigned long int) id->data; >=20 > Probably cast to enum msm_usb_phy_type will be better. will do. --=20 balbi --u3/rZRmxL6MmkK24 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJTZ6hDAAoJEIaOsuA1yqREZiIQAIhkDsnKTFrw4X3NbeNQrGvb Rkf1XNyQ9MjtzPnn6KdXH/zTPZoKh6cNUWYJ4wSStUe7+Sr1CZz0LzaVRj0nBzJg 1o7+dAjZDSidpl7Tk3Ys21cURbNvfrVqx52vzF12jvC5F7ckkmwkcc1+kwxL1qoY CKX1szllHD5hgs8ezoc7YCrcZYGIIR8HRMiM4DirhgsjbKrLURdbgBk4hJ6ms98B LRyueJJhBVPpOWRn4D8jQ+WCvYcpgOFIOiGanXrLJeSSLQh69zYTyAQtJdP8TXlV b2mhb8NKQQ/e92Go+gfDG8qe0GUbnqXcJ1jlkHszyNqtFPwsjOR7j2A9SR9kPnpo +q9IWqAiVTpGX7vhGfm3pzAFcXaaMUlWk5FpOeQgr6f6Efl++dujviGYriiUzOQl Kxa+oFBvWurQb30DgJHDjQhkDKHvHH9WcAblhM4rwiYQWWxPvmlyz0sfkO0F3PBC cRpG+pUQLMautXXypVe/iQ5FjwzWHBVcLj3ovRWHGfi0s8M5SWG52Bo20tQBigR9 MZjs83e2isvHV/6piRL03/WFnlJU2Iv6vNGzEu+WXUsUXFtwoOAceFqtkps80/f+ DYte965oy/His4HdljVahMKs3R2cZnxFQRhKAxOCLGiIXjCvoVPC92eksJFRXXZt wNXCZVlEiZ9WYZEIFryB =w4zf -----END PGP SIGNATURE----- --u3/rZRmxL6MmkK24--