From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID. Date: Tue, 13 May 2014 15:13:13 -0700 Message-ID: <20140513221313.GI20486@codeaurora.org> References: <1398759492-12970-1-git-send-email-srinivas.kandagatla@linaro.org> <1398759542-13017-1-git-send-email-srinivas.kandagatla@linaro.org> <5371E8B7.8000103@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5371E8B7.8000103@linaro.org> Sender: linux-mmc-owner@vger.kernel.org To: Srinivas Kandagatla Cc: Linus Walleij , Russell King , "linux-mmc@vger.kernel.org" , Chris Ball , Ulf Hansson , "linux-kernel@vger.kernel.org" , agross@quicinc.com, "linux-arm-msm@vger.kernel.org" List-Id: linux-arm-msm@vger.kernel.org On 05/13, Srinivas Kandagatla wrote: > Thanks Linus W, > > On 13/05/14 08:16, Linus Walleij wrote: > >On Tue, Apr 29, 2014 at 10:19 AM, wrote: > > > >>From: Srinivas Kandagatla > >> > >>This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci > >>driver. > >> > >>Signed-off-by: Srinivas Kandagatla > >(...) > >>+ AMBA_VENDOR_QCOM = 0x51, > > > >Yeah it's a "Q", like 0x41 is "A" for ARM. You could as well mention > >this in the commit message. > > > Sounds good, I will fix it in next version and send it to Russell's > patch tracker. > Please add a note that this id is fake in the commit text or in the code as well. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation