From: Mike Turquette <mturquette@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: qcom: Fix msm8660 GCC probe
Date: Fri, 16 May 2014 18:33:04 -0700 [thread overview]
Message-ID: <20140517013304.9521.38400@quantum> (raw)
In-Reply-To: <1400259914-28121-1-git-send-email-sboyd@codeaurora.org>
Quoting Stephen Boyd (2014-05-16 10:05:14)
> When consolidating the msm8660 GCC probe code I forgot to keep
> around these temporary clock registrations. Put them back so the
> clock tree is not entirely orphaned.
>
> Fixes: 49fc825f0cc2 (clk: qcom: Consolidate common probe code)
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Taken into clk-next.
Regards,
Mike
> ---
> drivers/clk/qcom/gcc-msm8660.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/clk/qcom/gcc-msm8660.c b/drivers/clk/qcom/gcc-msm8660.c
> index 44bc6fa64d78..0c4b727ae429 100644
> --- a/drivers/clk/qcom/gcc-msm8660.c
> +++ b/drivers/clk/qcom/gcc-msm8660.c
> @@ -2718,6 +2718,18 @@ MODULE_DEVICE_TABLE(of, gcc_msm8660_match_table);
>
> static int gcc_msm8660_probe(struct platform_device *pdev)
> {
> + struct clk *clk;
> + struct device *dev = &pdev->dev;
> +
> + /* Temporary until RPM clocks supported */
> + clk = clk_register_fixed_rate(dev, "cxo", NULL, CLK_IS_ROOT, 19200000);
> + if (IS_ERR(clk))
> + return PTR_ERR(clk);
> +
> + clk = clk_register_fixed_rate(dev, "pxo", NULL, CLK_IS_ROOT, 27000000);
> + if (IS_ERR(clk))
> + return PTR_ERR(clk);
> +
> return qcom_cc_probe(pdev, &gcc_msm8660_desc);
> }
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
prev parent reply other threads:[~2014-05-17 1:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 17:05 [PATCH] clk: qcom: Fix msm8660 GCC probe Stephen Boyd
2014-05-17 1:33 ` Mike Turquette [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140517013304.9521.38400@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).