From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: Fwd: Status of chipidea msm USB reset patch Date: Thu, 14 Aug 2014 11:54:02 -0500 Message-ID: <20140814165402.GA1445@saruman.home> References: Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pf9I7BMVVzbSWLtt" Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:39591 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751814AbaHNQys (ORCPT ); Thu, 14 Aug 2014 12:54:48 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Tim Bird , peter.chen@freescale.com Cc: "balbi@ti.com" , "Ivan T. Ivanov" , "linux-arm-msm@vger.kernel.org" , "linux-usb@vger.kernel.org" --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Aug 14, 2014 at 09:53:10AM -0700, Tim Bird wrote: > Ping. Anybody know the status of this patch? Is it queued in someone's = tree? > Without it the USB driver for the Qualcomm 8974 (hsusb phy) doesn't > work (at least for me). > It looks like it got dropped from Ivan's original patch series, back in M= ay. I don't maintain chipidea, Peter's the guy you want >=20 > ---------- Forwarded message ---------- > From: Tim Bird > Date: Fri, Jul 25, 2014 at 2:38 PM > Subject: Status of chipidea msm USB reset patch > To: linux-arm-msm@vger.kernel.org, balbi@ti.com, "Ivan T. Ivanov" > >=20 >=20 > Ivan and Felipe, >=20 > Do you know the status of the patch below? It was part of Ivan's > USB patch set, which got mainlined recently. However, this patch > did not show up in Linus' tree. >=20 > Is it in another tree on it's way, or does it need a re-submission? >=20 > I was recently testing the MSM USB gadget driver on the Dragonboard 800 > (with a Qualcomm 8974 processor), and without this patch the USB hardware > does not come up properly. >=20 > Thanks, > -- Tim >=20 >=20 > Subject: [PATCH] usb: chipidea: msm: Use USB PHY API to control PHY state >=20 > PHY drivers keep track of the current state of the hardware, > so don't change PHY settings under it. >=20 > Signed-off-by: Ivan T. Ivanov > --- > drivers/usb/chipidea/ci_hdrc_msm.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c > b/drivers/usb/chipidea/ci_hdrc_msm.c > index d72b9d2..81de834 100644 > --- a/drivers/usb/chipidea/ci_hdrc_msm.c > +++ b/drivers/usb/chipidea/ci_hdrc_msm.c > @@ -20,13 +20,11 @@ > static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event) > { > struct device *dev =3D ci->gadget.dev.parent; > - int val; >=20 > switch (event) { > case CI_HDRC_CONTROLLER_RESET_EVENT: > dev_dbg(dev, "CI_HDRC_CONTROLLER_RESET_EVENT received\n"); > - writel(0, USB_AHBBURST); > - writel(0, USB_AHBMODE); > + usb_phy_init(ci->transceiver); > break; > case CI_HDRC_CONTROLLER_STOPPED_EVENT: > dev_dbg(dev, "CI_HDRC_CONTROLLER_STOPPED_EVENT received\n"); > @@ -34,10 +32,7 @@ static void ci_hdrc_msm_notify_event(struct ci_hdrc > *ci, unsigned event) > * Put the transceiver in non-driving mode. Otherwise host > * may not detect soft-disconnection. > */ > - val =3D usb_phy_io_read(ci->transceiver, ULPI_FUNC_CTRL); > - val &=3D ~ULPI_FUNC_CTRL_OPMODE_MASK; > - val |=3D ULPI_FUNC_CTRL_OPMODE_NONDRIVING; > - usb_phy_io_write(ci->transceiver, val, ULPI_FUNC_CTRL); > + usb_phy_notify_disconnect(ci->transceiver, USB_SPEED_UNKNOWN); > break; > default: > dev_dbg(dev, "unknown ci_hdrc event\n"); > -- > 1.8.2.2 --=20 balbi --pf9I7BMVVzbSWLtt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJT7OmqAAoJEIaOsuA1yqRExCoP/2040QoTP9WNECb7NWn3e8wS uWqjKq1qHAlXXQJ0JIzYyN+9pLCoPOrPh6jHZV+IwdaTVBhAa1mZm12hfsyNbXW7 zg8qD6Bw+cP1IZW9D+gyyawT0Xme+7HTgdZ/cJAlS53wf0jzn9BmNC9vPPmKqEfk iP0HsyAzW57/j6DF1b7EKs5ETc1BL8oek6HtAWsmsCYi2kLQbsTXE//iCgQ8Sejs e0WDkCuMiFQMSMrG4DQO+XricoQqfHawkPGlkFViThuOcLn/qoFtlFiS+AniSRZH RFCzPZFcs4apN6aPH9T5uHkX9n7LRKTwDQdZAxPSNenChgKywH0QYWOkyDaj8kVJ uoTf18DRv67McGpbV2tWGGqjzayoabjjytC8YLRqpzSgzo5tj6xof4eP/PeXIEPE c636Ayw7VuxoraG5BnAKU5ZSn9qo/YlRTZBf9cO0FDgPfVGoYjhHJNenRESOt84l Ess7zArpRywIIWKZq/bo7KfaqBRysNKK9BKAYLx1Q7FTggKmQbogq5ogBoPfUU5t HSeKy692V0PBDjnY80rBCRIZxWWHfMT8XXL2F7K6IExpwNqU2KelSnFUKsYBls+z 60D4ctcWEICjmDJSSOd/v67amjDm3dluOkk7sWWRqDadj6TusgMWCvXp97ltViAJ 0mabcDiVUOIgG67G42Uv =i6Ht -----END PGP SIGNATURE----- --pf9I7BMVVzbSWLtt--